Bug 2231612 - Review Request: rust-glycin-utils - Sandboxed image rendering
Summary: Review Request: rust-glycin-utils - Sandboxed image rendering
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/glycin-utils
Whiteboard:
Depends On:
Blocks: 2233278
TreeView+ depends on / blocked
 
Reported: 2023-08-12 12:32 UTC by Kalev Lember
Modified: 2023-08-21 19:51 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-08-21 17:15:37 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Kalev Lember 2023-08-12 12:32:33 UTC
Spec URL: https://kalev.fedorapeople.org/rust-glycin-utils.spec
SRPM URL: https://kalev.fedorapeople.org/rust-glycin-utils-0.1.0~beta.2-2.fc40.src.rpm
Description: Sandboxed image rendering.
Fedora Account System Username: kalev

Comment 1 Fedora Review Service 2023-08-13 23:40:36 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6270616
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2231612-rust-glycin-utils/fedora-rawhide-x86_64/06270616-rust-glycin-utils/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-08-14 13:27:56 UTC
Please report the issue with the missing license file upstream.
Adding a symlink LICENSE -> ../LICENSE in the crate directories should be enough to have "cargo publish" pick them up.

Comment 3 Kalev Lember 2023-08-18 10:38:10 UTC
Thanks! I filed https://gitlab.gnome.org/sophie-h/glycin/-/merge_requests/9 for that.

Comment 4 Fabio Valentini 2023-08-21 15:44:37 UTC
Thank you, package looks good.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass (there are no tests)
! latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
~ license file is included with %license in %files (manually included from upstream)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Note that version 0.1.0-beta.3 was released a few days ago, please update the package soon after or before importing.

Comment 5 Fabio Valentini 2023-08-21 15:45:00 UTC
If you have a few minutes, it would be great if you could review one of my pending packages in return.

Comment 6 Kalev Lember 2023-08-21 16:41:17 UTC
Thanks a lot, Fabio! I'll definitely review some of your packages (but perhaps tomorrow).

Comment 7 Fedora Admin user for bugzilla script actions 2023-08-21 16:41:45 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-glycin-utils

Comment 8 Kalev Lember 2023-08-21 16:54:28 UTC
Package imported and build under way. It turns out I already had it updated locally to 0.1.0-beta.3 so it was just the matter of pushing it to the new repo :)

Comment 9 Fedora Update System 2023-08-21 17:11:51 UTC
FEDORA-2023-565277b482 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-565277b482

Comment 10 Fedora Update System 2023-08-21 17:14:35 UTC
FEDORA-2023-f46c3cfce5 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f46c3cfce5

Comment 11 Fedora Update System 2023-08-21 17:15:37 UTC
FEDORA-2023-565277b482 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2023-08-21 17:15:41 UTC
FEDORA-2023-f46c3cfce5 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.