Bug 2231712 - /usr/lib/firmware/a300_pm4.fw.xz: broken symbolic link to qcom/a300_pm4.fw.xz and /usr/lib/firmware/a300_pfp.fw.xz: broken symbolic link to qcom/a300_pfp.fw.xz
Summary: /usr/lib/firmware/a300_pm4.fw.xz: broken symbolic link to qcom/a300_pm4.fw.xz...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: linux-firmware
Version: 38
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: David Woodhouse
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-08-13 14:11 UTC by John Dodson
Modified: 2023-08-17 14:17 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)

Description John Dodson 2023-08-13 14:11:34 UTC
/usr/lib/firmware/a300_pm4.fw.xz: broken symbolic link to qcom/a300_pm4.fw.xz and /usr/lib/firmware/a300_pfp.fw.xz: broken symbolic link to qcom/a300_pfp.fw.xz



Reproducible: Always

Steps to Reproduce:
1. file /usr/lib/firmware/a300_pm4.fw.xz
2. file /usr/lib/firmware/a300_pfp.fw.xz
3.
Actual Results:  
Broken symlinks

Expected Results:  
No broken symlinks - a package must appropriately manage symlinks & create them
ONLY when the target is present.

Comment 1 Peter Robinson 2023-08-13 14:58:22 UTC
What version of firmware?

Comment 2 John Dodson 2023-08-14 02:43:20 UTC
linux-firmware-20230804-153.fc38.noarch

(I assume - as that's the owner of the links)

Where the links should be owned by the package that provides the target.

Comment 3 John Dodson 2023-08-14 02:45:46 UTC
2023-08-13T01:00:55+1000 SUBDEBUG Upgrade: linux-firmware-20230804-153.fc38.noarch

Comment 4 Peter Robinson 2023-08-17 11:34:39 UTC
> Where the links should be owned by the package that provides the target.

Yup, they were moved to the qcom-firmware sub package, but moving just the links is a lot of PITA logic for 2 links that basically don't cause an issue if you don't have the HW, and without the rest of the firmware for QCom HW you'll have other problems so it's unlikely I'll fix this until upstream drops the symlinks once the relevant affected kernels that may need this go EOL.

Comment 5 John Dodson 2023-08-17 14:08:39 UTC
"don't cause an issue" ???
Really?
Broken "system" symlinks are a very big issue for me.
This has been an issue previously eg. Lenovo links in the case of firmware.

They were fixed.

How do we "teach" the people creating such links to manage them appropriately?
Especially in "firmware" packages that could be subverted by a broken link?

They should not be allowed to be moved to another (sub?) package unless appropriately managed.
Regardless of the "work/logic" involved.

It's good practice.

Comment 6 Peter Robinson 2023-08-17 14:17:14 UTC
> Broken "system" symlinks are a very big issue for me.

But what is the "very big issue" that it causes from a technical PoV?

> This has been an issue previously eg. Lenovo links in the case of firmware.

Yes, because I took the time to fix it, I don't have that much time, I will eventually look into it but it's not currently high priority for me.


Note You need to log in before you can comment on or make changes to this bug.