Bug 2231712 - /usr/lib/firmware/a300_pm4.fw.xz: broken symbolic link to qcom/a300_pm4.fw.xz and /usr/lib/firmware/a300_pfp.fw.xz: broken symbolic link to qcom/a300_pfp.fw.xz
Summary: /usr/lib/firmware/a300_pm4.fw.xz: broken symbolic link to qcom/a300_pm4.fw.xz...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: linux-firmware
Version: 39
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: David Woodhouse
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2240878 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-08-13 14:11 UTC by John Dodson
Modified: 2024-03-26 02:45 UTC (History)
6 users (show)

Fixed In Version: linux-firmware-20240312-1.fc39 linux-firmware-20240312-1.fc40 linux-firmware-20240312-1.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-03-15 01:05:51 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description John Dodson 2023-08-13 14:11:34 UTC
/usr/lib/firmware/a300_pm4.fw.xz: broken symbolic link to qcom/a300_pm4.fw.xz and /usr/lib/firmware/a300_pfp.fw.xz: broken symbolic link to qcom/a300_pfp.fw.xz



Reproducible: Always

Steps to Reproduce:
1. file /usr/lib/firmware/a300_pm4.fw.xz
2. file /usr/lib/firmware/a300_pfp.fw.xz
3.
Actual Results:  
Broken symlinks

Expected Results:  
No broken symlinks - a package must appropriately manage symlinks & create them
ONLY when the target is present.

Comment 1 Peter Robinson 2023-08-13 14:58:22 UTC
What version of firmware?

Comment 2 John Dodson 2023-08-14 02:43:20 UTC
linux-firmware-20230804-153.fc38.noarch

(I assume - as that's the owner of the links)

Where the links should be owned by the package that provides the target.

Comment 3 John Dodson 2023-08-14 02:45:46 UTC
2023-08-13T01:00:55+1000 SUBDEBUG Upgrade: linux-firmware-20230804-153.fc38.noarch

Comment 4 Peter Robinson 2023-08-17 11:34:39 UTC
> Where the links should be owned by the package that provides the target.

Yup, they were moved to the qcom-firmware sub package, but moving just the links is a lot of PITA logic for 2 links that basically don't cause an issue if you don't have the HW, and without the rest of the firmware for QCom HW you'll have other problems so it's unlikely I'll fix this until upstream drops the symlinks once the relevant affected kernels that may need this go EOL.

Comment 5 John Dodson 2023-08-17 14:08:39 UTC
"don't cause an issue" ???
Really?
Broken "system" symlinks are a very big issue for me.
This has been an issue previously eg. Lenovo links in the case of firmware.

They were fixed.

How do we "teach" the people creating such links to manage them appropriately?
Especially in "firmware" packages that could be subverted by a broken link?

They should not be allowed to be moved to another (sub?) package unless appropriately managed.
Regardless of the "work/logic" involved.

It's good practice.

Comment 6 Peter Robinson 2023-08-17 14:17:14 UTC
> Broken "system" symlinks are a very big issue for me.

But what is the "very big issue" that it causes from a technical PoV?

> This has been an issue previously eg. Lenovo links in the case of firmware.

Yes, because I took the time to fix it, I don't have that much time, I will eventually look into it but it's not currently high priority for me.

Comment 7 John Dodson 2023-08-19 00:20:24 UTC
Thanks for fixing the previous firmware symlinks.
Your efforts in that are greatly appreciated.

In itself a broken symlink is not a problem, just as a failed engine on a 2 engine
aircraft will not cause a crash, just make it harder to land.

It does cause me to worry about the package(s) in general & the code.
Everything has bugs, it's the ones that coincide to create the final straw that
is the problem.

Avoiding the first obviates those that follow, making it good safe practice to deal
with something that's broken as quickly as possible.

The inter-relationship between packages, particularly those involved with hardware & the kernel
are interesting these days. (I mostly gave up kernels in the days of V6, V7 & SysV the last
being a driver for an image processor for 4.3bsd on a micro-vaxII & writing negative lines of code
was a sport).

It's nice to keep symlinks 'tidy", they are something that are easy to use to make life easier,
but they need to be managed carefully in many environments to avoid having them blow up
unexpectedly.

I'll wait for you to find time...

Cheers

John

Comment 8 Peter Robinson 2023-09-27 08:39:13 UTC
*** Bug 2240878 has been marked as a duplicate of this bug. ***

Comment 9 John Dodson 2023-11-08 02:58:45 UTC
Can we please add,

        /usr/lib/firmware/ath10k/WCN3990/hw1.0/wlanmdsp.mbn.xz

as another broken symlink?

It is claimed as owned by,

        atheros-firmware-20231030-1.fc38.noarch

but that cannot be selected when creating a new "bug".

Thanks

John

Comment 10 John Dodson 2023-11-28 00:13:07 UTC
At the risk of quoting Paul Simon...

Update Today (Tue 28 Nov 2023 11:11:34 AEDT):

/usr/lib/firmware/ath10k/WCN3990/hw1.0/wlanmdsp.mbn.xz: broken symbolic link to ../../../qcom/sdm845/wlanmdsp.mbn.xz
atheros-firmware-20231111-1.fc38.noarch

/usr/lib/firmware/a300_pfp.fw.xz: broken symbolic link to qcom/a300_pfp.fw.xz
linux-firmware-20231111-1.fc38.noarch

/usr/lib/firmware/a300_pm4.fw.xz: broken symbolic link to qcom/a300_pm4.fw.xz
linux-firmware-20231111-1.fc38.noarch

Comment 11 John Dodson 2023-12-04 19:54:39 UTC
All above still broken in FC39

Comment 12 John Dodson 2023-12-16 00:12:34 UTC
FYI, the following are still broken in,

/usr/lib/firmware/ath10k/WCN3990/hw1.0/wlanmdsp.mbn.xz: broken symbolic link to ../../../qcom/sdm845/wlanmdsp.mbn.xz
atheros-firmware-20231211-1.fc39.noarch


/usr/lib/firmware/a300_pm4.fw.xz: broken symbolic link to qcom/a300_pm4.fw.xz
linux-firmware-20231211-1.fc39.noarch

/usr/lib/firmware/a300_pfp.fw.xz: broken symbolic link to qcom/a300_pfp.fw.xz
linux-firmware-20231211-1.fc39.noarch

Comment 13 Peter Robinson 2023-12-16 13:43:31 UTC
(In reply to John Dodson from comment #12)
> FYI, the following are still broken in,

You are correct, you don't have to keep posting the same information.

Comment 14 John Dodson 2024-02-04 06:27:19 UTC
Peter, FYI, I will only try to post an update if there is a major change,
hopefully you don't mind an update after a month or so,
sadly it seems there is a new one, current list is...

/usr/lib/firmware/a300_pm4.fw.xz: broken symbolic link to qcom/a300_pm4.fw.xz
linux-firmware-20240115-2.fc39.noarch

/usr/lib/firmware/ath10k/WCN3990/hw1.0/wlanmdsp.mbn.xz: broken symbolic link to ../../../qcom/sdm845/wlanmdsp.mbn.xz
atheros-firmware-20240115-2.fc39.noarch

NEW...
/usr/lib/firmware/intel/ipu3-fw.bin.xz: broken symbolic link to irci_irci_ecr-master_20161208_0213_20170112_1500.bin.xz
linux-firmware-20240115-2.fc39.noarch

/usr/lib/firmware/a300_pfp.fw.xz: broken symbolic link to qcom/a300_pfp.fw.xz
linux-firmware-20240115-2.fc39.noarch

Comment 15 Peter Robinson 2024-02-20 22:12:32 UTC
> Peter, FYI, I will only try to post an update if there is a major change,
> hopefully you don't mind an update after a month or so,

If it's just repeating the same I'm not sure what value it provides. If there's additions it's a fine update :)

> NEW...
> /usr/lib/firmware/intel/ipu3-fw.bin.xz: broken symbolic link to
> irci_irci_ecr-master_20161208_0213_20170112_1500.bin.xz
> linux-firmware-20240115-2.fc39.noarch

That one will be fixed in the update going out now I believe (Feb release).

> /usr/lib/firmware/a300_pfp.fw.xz: broken symbolic link to qcom/a300_pfp.fw.xz
> linux-firmware-20240115-2.fc39.noarch

That one is in you original report in comment 1. I have a fix for that but it won't land until next month along with any others.

Comment 16 John Dodson 2024-02-22 04:11:07 UTC
OK thanks.

Comment 17 Fedora Update System 2024-03-12 20:26:20 UTC
FEDORA-2024-b14b34f640 (linux-firmware-20240312-1.fc38) has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-b14b34f640

Comment 18 Fedora Update System 2024-03-12 20:26:27 UTC
FEDORA-2024-86a6245c69 (linux-firmware-20240312-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-86a6245c69

Comment 19 Fedora Update System 2024-03-12 20:26:35 UTC
FEDORA-2024-e62bcaf172 (linux-firmware-20240312-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e62bcaf172

Comment 20 Peter Robinson 2024-03-12 20:32:30 UTC
> /usr/lib/firmware/ath10k/WCN3990/hw1.0/wlanmdsp.mbn.xz: broken symbolic link
> to ../../../qcom/sdm845/wlanmdsp.mbn.xz
> atheros-firmware-20240115-2.fc39.noarch

This one has an outstanding PR upstream, we should see that in the April release, all the rest are now fixed.

Comment 21 Fedora Update System 2024-03-13 01:13:56 UTC
FEDORA-2024-b14b34f640 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b14b34f640`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b14b34f640

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 22 Fedora Update System 2024-03-13 02:11:52 UTC
FEDORA-2024-86a6245c69 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-86a6245c69`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-86a6245c69

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 23 Fedora Update System 2024-03-13 02:26:41 UTC
FEDORA-2024-e62bcaf172 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-e62bcaf172`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-e62bcaf172

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 24 John Dodson 2024-03-14 00:18:08 UTC
Thanks Peter! Greatly appreciated.

Comment 25 Fedora Update System 2024-03-15 01:05:51 UTC
FEDORA-2024-86a6245c69 (linux-firmware-20240312-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 26 Fedora Update System 2024-03-23 00:35:09 UTC
FEDORA-2024-e62bcaf172 (linux-firmware-20240312-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 27 Fedora Update System 2024-03-26 02:45:46 UTC
FEDORA-2024-b14b34f640 (linux-firmware-20240312-1.fc38) has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.