Bug 2231940 - Review Request: golang-modernc-cc -Package CC is a C99 compiler front end
Summary: Review Request: golang-modernc-cc -Package CC is a C99 compiler front end
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2231426 2231937
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2023-08-14 17:59 UTC by W. Michael Petullo
Modified: 2023-09-20 00:45 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-09-20 00:45:32 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description W. Michael Petullo 2023-08-14 17:59:08 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-cc.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-cc-3.39.0-1.fc38.src.rpm
Description: Package CC is a C99 compiler front end
Fedora Account System Username: mikep

Comment 1 Robert-André Mauchin 🐧 2023-08-20 17:09:58 UTC
I'm not okay with that SPEC:

# https://gitlab.com/cznic/cc
%global goipath         modernc.org/cc
%global forgeurl        https://gitlab.com/cznic/cc
Version:                3.39.0


Latest version in v3 is v3.41.0

If you want to package v3, use the v3 import path:

modernc.org/cc/v3


And thus call your package:

golang-modernc-cc-3


(including the spec filename and this bug title)

 - Then, like I said in my mail:

find . ! \( -name v3 -o -name _build \) -maxdepth 1 -exec rm -rvf {} \;
mv v3/* . 


-> we delete all the files except v3, and we move v3 files to the root of the packages.


SPEC should look like this:

# golang-modernc-cc.spec
# Generated by go2rpm 1.9.0
%bcond_without check
%global debug_package %{nil}

# https://gitlab.com/cznic/cc
%global goipath         modernc.org/cc/v3
%global forgeurl        https://gitlab.com/cznic/cc
Version:                3.41.0
%global tag             v%{version}

%gometa -f

%global common_description %{expand:
Package CC is a C99 compiler front end.}

%global golicenses      GO-LICENSE LICENSE
%global godocs          docs README.md AUTHORS CONTRIBUTORS

Name:           %{goname}
Release:        %autorelease
Summary:        C99 compiler front end

License:        BSD-3-Clause
URL:            %{gourl}
Source:         %{gosource}
Patch:          cc-v3.39.0-s390x.patch

%description %{common_description}

%gopkg

%prep
%goprep
%autopatch -p1
find . ! \( -name v3 -o -name _build \) -maxdepth 1 -exec rm -rvf {} \;
mv v3/* .

%generate_buildrequires
%go_generate_buildrequires

%install
%gopkginstall

%if %{with check}
%check
%gocheck
%endif

%gopkgfiles

%changelog
%autochangelog

Comment 2 Package Review 2023-09-20 00:45:32 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.