Copr build:
https://copr.fedorainfracloud.org/coprs/build/6300120
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2232229-atlantik/fedora-rawhide-x86_64/06300120-atlantik/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* Creative Commons CC0 1.0", "Unknown or
     generated", "GNU General Public License, Version 2", "GNU Lesser
     General Public License, Version 2.1". 110 files have unknown license.
     Detailed output of licensecheck in
     /home/FedoraPackaging/reviews/atlantik/2232229-atlantik/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/doc/HTML/sv,
     /usr/share/doc/HTML/en, /usr/share/doc/HTML/es,
     /usr/share/doc/HTML/nl, /usr/share/doc/HTML/uk,
     /usr/share/doc/HTML/ca, /usr/share/doc/HTML/it,
     /usr/share/doc/HTML/de, /usr/share/doc/HTML
[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/share/doc/HTML/de/atlantik(kde-i18n-German),
     /usr/share/doc/HTML/en/atlantik(kdegames3),
     /usr/share/doc/HTML/es/atlantik(kde-i18n-Spanish),
     /usr/share/doc/HTML/it/atlantik(kde-i18n-Italian),
     /usr/share/doc/HTML/nl/atlantik(kde-i18n-Dutch),
     /usr/share/doc/HTML/sv/atlantik(kde-i18n-Swedish)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[ ]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 219130 bytes in 19 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     atlantik-libs , atlantik-devel
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: atlantik-0.7.80~20230806.git01397fd-1.fc38.x86_64.rpm
          atlantik-libs-0.7.80~20230806.git01397fd-1.fc38.x86_64.rpm
          atlantik-devel-0.7.80~20230806.git01397fd-1.fc38.x86_64.rpm
          atlantik-debuginfo-0.7.80~20230806.git01397fd-1.fc38.x86_64.rpm
          atlantik-debugsource-0.7.80~20230806.git01397fd-1.fc38.x86_64.rpm
          atlantik-0.7.80~20230806.git01397fd-1.fc38.src.rpm
============================================ rpmlint session starts ============================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpk4kao3sb')]
checks: 31, packages: 6

atlantik.src: W: strange-permission atlantik.spec 600
atlantik-devel.x86_64: W: obsolete-not-provided kdegames3-devel
atlantik-devel.x86_64: W: no-documentation
============= 6 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 4.7 s =============




Rpmlint (debuginfo)
-------------------
Checking: atlantik-debuginfo-0.7.80~20230806.git01397fd-1.fc38.x86_64.rpm
          atlantik-libs-debuginfo-0.7.80~20230806.git01397fd-1.fc38.x86_64.rpm
============================================ rpmlint session starts ============================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpakb59qct')]
checks: 31, packages: 2

============= 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 2.9 s =============





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 6

atlantik-devel.x86_64: W: obsolete-not-provided kdegames3-devel
atlantik-devel.x86_64: W: no-documentation
 6 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 8.3 s 



Source checksums
----------------
https://invent.kde.org/games/atlantik/-/archive/01397fd60153802cfce6b96af3265ee65079b50b/atlantik-01397fd60153802cfce6b96af3265ee65079b50b.tar.bz2 :
  CHECKSUM(SHA256) this package     : 9e0b36239730b85eed05f7dbb6ceef4ad0009d9c9bdc9af3223ee634e3bc238e
  CHECKSUM(SHA256) upstream package : 9e0b36239730b85eed05f7dbb6ceef4ad0009d9c9bdc9af3223ee634e3bc238e


Requires
--------
atlantik (rpmlib, GLIBC filtered):
    atlantik-libs(x86-64)
    hicolor-icon-theme
    libKF5ConfigCore.so.5()(64bit)
    libKF5ConfigGui.so.5()(64bit)
    libKF5ConfigWidgets.so.5()(64bit)
    libKF5CoreAddons.so.5()(64bit)
    libKF5Crash.so.5()(64bit)
    libKF5I18n.so.5()(64bit)
    libKF5IconThemes.so.5()(64bit)
    libKF5KDEGames.so.7()(64bit)
    libKF5Notifications.so.5()(64bit)
    libKF5NotifyConfig.so.5()(64bit)
    libKF5WidgetsAddons.so.5()(64bit)
    libKF5XmlGui.so.5()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.15)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Network.so.5()(64bit)
    libQt5Network.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libatlantic.so.5()(64bit)
    libatlantikclient.so.5()(64bit)
    libatlantikui.so.5()(64bit)
    libc.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

atlantik-libs (rpmlib, GLIBC filtered):
    libKF5I18n.so.5()(64bit)
    libKF5IconThemes.so.5()(64bit)
    libKF5WidgetsAddons.so.5()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.15)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Network.so.5()(64bit)
    libQt5Network.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libQt5Xml.so.5()(64bit)
    libQt5Xml.so.5(Qt_5)(64bit)
    libatlantic.so.5()(64bit)
    libc.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

atlantik-devel (rpmlib, GLIBC filtered):
    atlantik-libs(x86-64)
    cmake-filesystem(x86-64)
    libatlantic.so.5()(64bit)
    libatlantikui.so.5()(64bit)

atlantik-debuginfo (rpmlib, GLIBC filtered):

atlantik-debugsource (rpmlib, GLIBC filtered):



Provides
--------
atlantik:
    application()
    application(org.kde.atlantik.desktop)
    atlantik
    atlantik(x86-64)
    metainfo()
    metainfo(org.kde.atlantik.appdata.xml)

atlantik-libs:
    atlantik-libs
    atlantik-libs(x86-64)
    libatlantic.so.5()(64bit)
    libatlantikclient.so.5()(64bit)
    libatlantikui.so.5()(64bit)

atlantik-devel:
    atlantik-devel
    atlantik-devel(x86-64)
    cmake(Atlantik)
    cmake(atlantik)

atlantik-debuginfo:
    atlantik-debuginfo
    atlantik-debuginfo(x86-64)
    debuginfo(build-id)

atlantik-debugsource:
    atlantik-debugsource
    atlantik-debugsource(x86-64)



Diff spec file in url and in SRPM
---------------------------------
--- /home/FedoraPackaging/reviews/atlantik/2232229-atlantik/srpm/atlantik.spec  2023-08-16 12:53:51.338937435 +0300
+++ /home/FedoraPackaging/reviews/atlantik/2232229-atlantik/srpm-unpacked/atlantik.spec 2023-08-15 03:00:00.000000000 +0300
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.3.5)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 1;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 %global commit 01397fd60153802cfce6b96af3265ee65079b50b
 %global shortcommit %(c=%{commit}; echo ${c:0:7})
@@ -119,3 +129,4 @@
 
 %changelog
-%autochangelog
+* Tue Aug 15 2023 Yaakov Selkowitz <yselkowi> - 0.7.80~20230806.git01397fd-1
+- Initial import


Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2232229 -m fedora-38-x86_64
Buildroot used: fedora-38-x86_64
Active plugins: C/C++, Shell-api, Generic
Disabled plugins: Ruby, Java, PHP, R, Perl, SugarActivity, fonts, Python, Ocaml, Haskell
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) Builds on all architectures:
https://copr.fedorainfracloud.org/coprs/fed500/atlantik/build/6305603/
b) The latest version of fedora-review gives:
Note: Directories without known owners: /usr/share/doc/HTML/nl,
     /usr/share/doc/HTML/sv, /usr/share/doc/HTML/es,
     /usr/share/doc/HTML/ca, /usr/share/doc/HTML, /usr/share/doc/HTML/uk,
     /usr/share/doc/HTML/de, /usr/share/doc/HTML/it, /usr/share/doc/HTML/en
see:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2232229-atlantik/fedora-rawhide-x86_64/06300120-atlantik/fedora-review/review.txt
Should these be co-owned?
c) A further warning:
atlantik-devel.x86_64: W: obsolete-not-provided kdegames3-devel

>[!]: Spec file according to URL is the same as in SRPM.
>     Note: Spec file as given by url is not the same as in SRPM (see
>     attached diff).

This is due to use of rpmautospec.

> b) The latest version of fedora-review gives:
> Note: Directories without known owners: /usr/share/doc/HTML/nl,
>      /usr/share/doc/HTML/sv, /usr/share/doc/HTML/es,
>      /usr/share/doc/HTML/ca, /usr/share/doc/HTML, /usr/share/doc/HTML/uk,
>      /usr/share/doc/HTML/de, /usr/share/doc/HTML/it, /usr/share/doc/HTML/en
> see:
> https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-
> review-2232229-atlantik/fedora-rawhide-x86_64/06300120-atlantik/fedora-
> review/review.txt
> Should these be co-owned?

First, the files are these directories are handled entirely by `%find_lang`.  kde-filesystem does provide those but otherwise it is really intended for KDE 3 and 4.  Some modern KDE apps still Requires: kde-filesystem but many do not, so this must be a frequent issue.  I can add the requires if you insist but I think we're looking at a bigger issue here that should probably be solved at a higher level (either by having %find_lang generate %dir's to co-own these, or being stricter about Requires: kde-filesystem across the distro, or adding these directories to a more modern *-filesystem package).

> c) A further warning:
> atlantik-devel.x86_64: W: obsolete-not-provided kdegames3-devel

In this particular case I believe this is appropriate (which is why it is a warning and not an error).  It should replace the deprecated kdegames3-devel if installed but if someone were to (try to) install kdegames3-devel (which simply by its name implies KDE3) I don't think they would want the KDE 5 atlantik-devel.

(In reply to Yaakov Selkowitz from comment #3)
> First, the files are these directories are handled entirely by `%find_lang`.
> kde-filesystem does provide those but otherwise it is really intended for
> KDE 3 and 4.  Some modern KDE apps still Requires: kde-filesystem but many
> do not, so this must be a frequent issue.  I can add the requires if you
> insist but I think we're looking at a bigger issue here that should probably
> be solved at a higher level (either by having %find_lang generate %dir's to
> co-own these, or being stricter about Requires: kde-filesystem across the
> distro, or adding these directories to a more modern *-filesystem package).

Filed https://pagure.io/fedora-kde/SIG/issue/378 for further discussion; my best suggestion atm is that they should (also) be provided by kf5-filesystem, but we'll see what KDE SIG says.

I'd rather that not block the review though, as atlantik has (unfortunately prematurely) already been removed from kdegames3, even though my intention was that PR to wait until this was complete.

Ok. Approved. Please ensure those directories have an owner either using %dir in the spec or adding Requires: kde-filesystem, and then changing appropriately depending on SIG outcome.

The Pagure repository was created at https://src.fedoraproject.org/rpms/atlantik

Thanks for the review!

> Some modern KDE apps still Requires: kde-filesystem but many do not, so this must be a frequent issue.

Then this is a bug in the application packages, or in the libraries they use (really every kf5-* should require kde-filesystem). Splitting a small package with basically no files (except that RPM macro file) into subpackages just makes it larger, because metadata is not free.