Bug 2239242 - Review Request: fedora-ima - IMA policies and configuration files
Summary: Review Request: fedora-ima - IMA policies and configuration files
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-09-16 11:41 UTC by Coiby
Modified: 2025-06-04 02:50 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-06-04 02:50:04 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Coiby 2023-09-16 11:41:22 UTC
Spec URL: https://coiby.fedorapeople.org/fedora-ima.spec
SRPM URL: fedora-ima-0.1-1.fc40.src.rpm
Description: This package contains IMA sample policies and enable the dracut integrity module to make it easier to load IMA keys and policies.
Fedora Account System Username: coiby

Comment 1 Petr Menšík 2023-10-09 09:59:50 UTC
It is quite unusual to have a package without upstream URL. Why is this package a separate source if it does not have any upstream repository? Wouldn't it make sense to create fedora-specific subpackage to any package it is related to?

It does not explain what IMA stands for, which packages use it and for what exactly. I think at least README.md with a bit more descriptive text how and for what this is used would be useful. Especially with some links to more detailed page. Would a good candidate be [1]?

I think all files installed into /etc should have %config(noreplace) added to them, unless very special case.

The spec lacks %prep section, where %autosetup should be present. I think it expands it into long description, which should not be done.

I would say if this package does not have any upstream, it should have version 0 only. Release incrementals should be enough, until some upstream archive is used with any version assigned to it.

1. https://sourceforge.net/p/linux-ima/wiki/Home/

Comment 2 Zbigniew Jędrzejewski-Szmek 2024-05-23 14:44:18 UTC
Also, since there's no upstream, and the srpm link is not provided, it's not really possible to review the contents :(

Comment 3 Package Review 2025-05-24 00:45:27 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 4 Coiby 2025-06-04 02:50:04 UTC
Thank Petr and Zbigniew for the feedback! This functions provided by this package are now contained in the ima-evm-utils package.


Note You need to log in before you can comment on or make changes to this bug.