Bug 225263 - Merge Review: aspell-da
Merge Review: aspell-da
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-29 16:03 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-04-10 23:24:00 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-29 16:03:23 EST
Fedora Merge Review: aspell-da

http://cvs.fedora.redhat.com/viewcvs/devel/aspell-da/
Comment 1 Parag AN(पराग) 2007-03-28 00:37:38 EDT
Can you update SPEC as suggested in other aspell package reviews?
Comment 2 Parag AN(पराग) 2007-03-28 03:35:35 EDT
I saw new tarball available on upstream site aspell5-da-1.4.42-1.tar.gz2. 
Can you update source in SPEC?
Comment 3 Ivana Varekova 2007-03-28 14:01:58 EDT
Thank you for your notice, fixed in aspell-da-1.4.42-1.fc7.i386.rpm.
Comment 4 Parag AN(पराग) 2007-03-28 23:38:12 EDT
 package builds in mock (development i386).
- rpmlint is NOT silent for SRPM and RPM.
  But following messages are ignorable
  E: aspell-da no-binary
  E: aspell-da only-non-binary-in-usr-lib
  E: aspell-da configure-without-libdir-spec
+ SPEC file contains explanation about above warnings.
+ source files match upstream.
+ package meets naming and packaging guidelines.
d14c03dca23b572606279d7317b022d0  aspell5-da-1.4.42-1.tar.bz2
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Requires: aspell >= 12:0.60
+ Provides: aspell-da = 50:1.4.42-1.fc7
+ Not a GUI APP.

APPROVED.
Comment 5 Parag AN(पराग) 2007-04-10 23:24:00 EDT
As build is available now, therefore CLOSING this review.

Note You need to log in before you can comment on or make changes to this bug.