This service will be undergoing maintenance at 00:00 UTC, 2016-09-28. It is expected to last about 1 hours
Bug 225291 - Merge Review: audiofile
Merge Review: audiofile
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Matthias Clasen
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-29 16:07 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-08-10 21:29:26 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
bdpepple: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-29 16:07:23 EST
Fedora Merge Review: audiofile

http://cvs.fedora.redhat.com/viewcvs/devel/audiofile/
Comment 1 Brian Pepple 2007-02-03 17:54:02 EST
Good:
* Source URL is canonical
* Group Tag is from the official list

Needs to be Fixed:
* rpmlint error: W: audiofile no-url-tag
* Requires for devel package should be:
 Requires: %{name} = %{epoch}:%{version}-%{release}

Minor:
* Remove the '.' from the summaries to quite rpmlint.
* Doesn't use the preferred buildroot.
http://fedoraproject.org/wiki/Packaging/Guidelines#head-f196e7b2477c2f5dd97ef64e8eacddfb517f1aa1
* I don't believe the 'Prereq: /sbin/ldconfig' is needed.

Comment 2 Matthias Clasen 2007-02-03 21:15:03 EST
I've corrected these things in audiofile-0.2.6-6.fc7
Comment 3 Brian Pepple 2007-02-04 13:07:02 EST
Changes look good. +1 Approved
Comment 4 Matthias Clasen 2007-08-10 21:29:26 EDT
Review done.

Note You need to log in before you can comment on or make changes to this bug.