Bug 225291 - Merge Review: audiofile
Summary: Merge Review: audiofile
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matthias Clasen
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-01-29 21:07 UTC by Nobody's working on this, feel free to take it
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2007-08-11 01:29:26 UTC
Type: ---
Embargoed:
bdpepple: fedora-review+

Attachments (Terms of Use)

Description Nobody's working on this, feel free to take it 2007-01-29 21:07:23 UTC 
Fedora Merge Review: audiofile

http://cvs.fedora.redhat.com/viewcvs/devel/audiofile/
Comment 1 Brian Pepple 2007-02-03 22:54:02 UTC 
Good:
* Source URL is canonical
* Group Tag is from the official list

Needs to be Fixed:
* rpmlint error: W: audiofile no-url-tag
* Requires for devel package should be:
 Requires: %{name} = %{epoch}:%{version}-%{release}

Minor:
* Remove the '.' from the summaries to quite rpmlint.
* Doesn't use the preferred buildroot.
http://fedoraproject.org/wiki/Packaging/Guidelines#head-f196e7b2477c2f5dd97ef64e8eacddfb517f1aa1
* I don't believe the 'Prereq: /sbin/ldconfig' is needed.
Comment 2 Matthias Clasen 2007-02-04 02:15:03 UTC 
I've corrected these things in audiofile-0.2.6-6.fc7
Comment 3 Brian Pepple 2007-02-04 18:07:02 UTC 
Changes look good. +1 Approved
Comment 4 Matthias Clasen 2007-08-11 01:29:26 UTC 
Review done.
Note You need to log in before you can comment on or make changes to this bug.