Red Hat Bugzilla – Bug 225345
Review Request: kodos - Visual regular expression editor
Last modified: 2007-11-30 17:11:54 EST
Spec URL: http://blues.mcgill.ca/~icon/fe/kodos.spec
SRPM URL: http://blues.mcgill.ca/~icon/fe/kodos-2.4.9-1.src.rpm
Kodos is a visual regular expression editor and debugger written in Python.
Mostly looks good, full review to follow but thought I'd note this first:
# rpmlint -i kodos
E: kodos non-executable-script /usr/lib/python2.4/site-packages/kodos/kodos.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed. If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.
I think you want to pull the shebang. Or, perhaps not even package it as it is
basically the same as /usr/bin/kodos?
mock build fails:
+ desktop-file-install --vendor fedora --dir
/var/tmp/rpm-tmp.24776: line 36: desktop-file-install: command not found
Looks like you need:
I apologize for the delay. This is tested to build in mock, pass all rpmlint
checks, and known to work. :)
- rpmlint checks return:
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- There is no license/copyright/author information in the source files
themselves. Please ping upstream about getting this added. Not a blocker per
se, since the project clearly inteads to be GPLv2.
- No need for X-Fedora in desktop-file-install
- No need for update-desktop-database - no MimeType key in .desktop file
Sorry for the delay, again. I swear it will be speedy from now on. :)
Looks good to me. I would change:
because personally I like to list things out. Helps detect when things change.
But I'll leave that up to your preference.
New Package CVS Request
Package Name: kodos
Short Description: Visual regular expression editor
Branches: FC-6 F-7 EL-5
From cvs commit log:
However, there is no %post or %postun.