Bug 2254918 - Review Request: perl-Module-Build-Prereqs-FromCPANfile - Construct prereq parameters of Module::Build from cpanfile
Summary: Review Request: perl-Module-Build-Prereqs-FromCPANfile - Construct prereq par...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2254926
TreeView+ depends on / blocked
 
Reported: 2023-12-17 22:39 UTC by Chris Adams
Modified: 2024-05-15 18:56 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-05-15 15:17:42 UTC
Type: ---
Embargoed:
ppisar: fedora-review+


Attachments (Terms of Use)

Description Chris Adams 2023-12-17 22:39:58 UTC
Spec URL: https://cmadams.fedorapeople.org/perl-Module-Build-Prereqs-FromCPANfile/perl-Module-Build-Prereqs-FromCPANfile.spec
SRPM URL: https://cmadams.fedorapeople.org/perl-Module-Build-Prereqs-FromCPANfile/perl-Module-Build-Prereqs-FromCPANfile-0.02-1.fc39.src.rpm
Description:
This simple module reads cpanfile and converts its content into valid
prereq parameters for new() method of Module::Build.

Fedora Account System Username: cmadams

Comment 4 Petr Pisar 2024-05-03 12:03:41 UTC
URL and Source0 addresses are Ok.
Source0 archive (SHA-512 29078020fb2638c9032cc28ca37caa12b530a6302be099dce437f89536dc5aae9aaacdecf42c6c7b2d41c40443eb03a8008855068f47ff203c75024e5175c8cd) is original. Ok.
Summary verified from lib/Module/Build/Prereqs/FromCPANfile.pm. Ok.
Description verified from lib/Module/Build/Prereqs/FromCPANfile.pm. Ok.
License verified from Build.PL, README, and lib/Module/Build/Prereqs/FromCPANfile.pm. Ok.
No XS code, noarch BuildArch is Ok.

FIX: Change 'perl(:VERSION) >= 5.14.0' to 'perl(:VERSION) >= 5.6.0'. The 5.14.0 value in tests is never compared against running perl. 5.6.0 is at Build.PL:1.

All tests pass. Ok.

$ rpmlint perl-Module-Build-Prereqs-FromCPANfile.spec ../SRPMS/perl-Module-Build-Prereqs-FromCPANfile-0.02-4.fc41.src.rpm ../RPMS/noarch/perl-Module-Build-Prereqs-FromCPANfile-0.02-4.fc41.noarch.rpm 
======================================== rpmlint session starts =======================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

=== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0 badness; has taken 0.3 s ==
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Module-Build-Prereqs-FromCPANfile-0.02-4.fc41.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Mar  8 01:00 /usr/share/doc/perl-Module-Build-Prereqs-FromCPANfile
-rw-r--r--    1 root     root                      276 Aug 16  2014 /usr/share/doc/perl-Module-Build-Prereqs-FromCPANfile/Changes
-rw-r--r--    1 root     root                     1702 Aug 16  2014 /usr/share/doc/perl-Module-Build-Prereqs-FromCPANfile/README
-rw-r--r--    1 root     root                     1997 Mar  8 01:00 /usr/share/man/man3/Module::Build::Prereqs::FromCPANfile.3pm.gz
drwxr-xr-x    2 root     root                        0 Mar  8 01:00 /usr/share/perl5/vendor_perl/Module/Build/Prereqs
-rw-r--r--    1 root     root                     4359 Mar  8 01:00 /usr/share/perl5/vendor_perl/Module/Build/Prereqs/FromCPANfile.pm
File layout and permissions are Ok.
Note: Missing %{perl_vendorlib}/Module/Build path components will be provided by perl-Module-Build which you will hard-require.

$ rpm -q --requires -p ../RPMS/noarch/perl-Module-Build-Prereqs-FromCPANfile-0.02-4.fc41.noarch.rpm | sort -f | uniq -c 
      1 perl(CPAN::Meta::Prereqs) >= 2.132830
      1 perl(Exporter)
      1 perl(Module::CPANfile) >= 1.0000
      1 perl(strict)
      1 perl(version) >= 0.80
      1 perl(warnings)
      1 perl-libs
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
FIX: Run-require 'perl(Module::Build)' (lib/Module/Build/Prereqs/FromCPANfile.pm:25).

$ rpm -q --recommends -p ../RPMS/noarch/perl-Module-Build-Prereqs-FromCPANfile-0.02-4.fc41.noarch.rpm | sort -f | uniq -c 
      1 perl(Module::Build) >= 0.4004
Soft dependencies are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Module-Build-Prereqs-FromCPANfile-0.02-4.fc41.noarch.rpm | sort -f | uniq -c 
      1 perl(Module::Build::Prereqs::FromCPANfile) = 0.02
      1 perl-Module-Build-Prereqs-FromCPANfile = 0.02-4.fc41
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Module-Build-Prereqs-FromCPANfile-0.02-4.fc41.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in Fedora 41 (https://koji.fedoraproject.org/koji/taskinfo?taskID=117192852). Ok.

Otherwise, the package is in line with Fedora and Perl packaging guidelines.

Please correct the FIX items and provide an updated spec file.

Comment 6 Petr Pisar 2024-05-06 09:01:09 UTC
Changes in the spec file:

--- perl-Module-Build-Prereqs-FromCPANfile.spec.old     2024-03-08 01:00:00.000000000 +0100
+++ perl-Module-Build-Prereqs-FromCPANfile.spec 2024-05-03 02:00:00.000000000 +0200
@@ -1,13 +1,13 @@
 Name:           perl-Module-Build-Prereqs-FromCPANfile
 Version:        0.02
-Release:        4%{?dist}
+Release:        5%{?dist}
 Summary:        Construct prereq parameters of Module::Build from cpanfile
 License:        GPL-1.0-or-later OR Artistic-1.0-Perl
 URL:            https://metacpan.org/dist/Module-Build-Prereqs-FromCPANfile
 Source0:        https://cpan.metacpan.org/authors/id/T/TO/TOSHIOITO/Module-Build-Prereqs-FromCPANfile-%{version}.tar.gz
 BuildArch:      noarch
 BuildRequires:  perl-interpreter perl-generators coreutils
-BuildRequires:  perl(:VERSION) >= 5.14.0
+BuildRequires:  perl(:VERSION) >= 5.6.0
 BuildRequires:  perl(CPAN::Meta::Prereqs) >= 2.132830
 BuildRequires:  perl(Exporter)
 BuildRequires:  perl(Module::Build) >= 0.42
@@ -16,7 +16,7 @@
 BuildRequires:  perl(version) >= 0.80
 BuildRequires:  perl(strict)
 BuildRequires:  perl(warnings)
-Recommends:     perl(Module::Build) >= 0.4004
+Requires:       perl(Module::Build) >= 0.4004
 
 %description
 This simple module reads cpanfile and converts its content into valid
@@ -42,6 +42,9 @@
 %{_mandir}/man3/Module::Build::Prereqs*
 
 %changelog
+* Fri May 03 2024 Chris Adams <linux> 0.02-5
+- additional spec file cleanups
+
 * Fri Mar 08 2024 Chris Adams <linux> 0.02-4
 - additional spec file cleanups


$ rpmlint perl-Module-Build-Prereqs-FromCPANfile.spec ../SRPMS/perl-Module-Build-Prereqs-FromCPANfile-0.02-5.fc41.src.rpm ../RPMS/noarch/perl-Module-Build-Prereqs-FromCPANfile-0.02-5.fc41.noarch.rpm 
======================================== rpmlint session starts =======================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

=== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0 badness; has taken 0.3 s ==
rpmlint is Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Module-Build-Prereqs-FromCPANfile-0.02-5.fc41.noarch.rpm | sort -f | uniq -c
      1 perl(CPAN::Meta::Prereqs) >= 2.132830
      1 perl(Exporter)
      1 perl(Module::Build) >= 0.4004
      1 perl(Module::CPANfile) >= 1.0000
      1 perl(strict)
      1 perl(version) >= 0.80
      1 perl(warnings)
      1 perl-libs
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ resolvedeps rawhide  ../RPMS/noarch/perl-Module-Build-Prereqs-FromCPANfile-0.02-5.fc41.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in Fedora 41 (https://koji.fedoraproject.org/koji/taskinfo?taskID=117325797). Ok.

The package is in line with Fedora and Perl packaging guidelines.
The pacakge is APPROVED.

Comment 7 Fedora Update System 2024-05-06 21:11:45 UTC
FEDORA-2024-99e2a2385c (perl-Module-Build-Prereqs-FromCPANfile-0.02-5.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-99e2a2385c

Comment 8 Fedora Update System 2024-05-06 21:18:03 UTC
FEDORA-2024-dc50502d90 (perl-Module-Build-Prereqs-FromCPANfile-0.02-5.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-dc50502d90

Comment 9 Fedora Update System 2024-05-07 02:20:03 UTC
FEDORA-2024-99e2a2385c has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-99e2a2385c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-99e2a2385c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-05-07 04:56:30 UTC
FEDORA-2024-dc50502d90 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-dc50502d90 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-dc50502d90

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-05-15 15:17:42 UTC
FEDORA-2024-99e2a2385c (perl-Module-Build-Prereqs-FromCPANfile-0.02-5.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2024-05-15 18:56:51 UTC
FEDORA-2024-dc50502d90 (perl-Module-Build-Prereqs-FromCPANfile-0.02-5.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.