Fedora Merge Review: byacc http://cvs.fedora.redhat.com/viewcvs/devel/byacc/ Initial Owner: pmachata
Commited and built for rawhide updated and tidied-up version. Rpmlint silent for both binary and source rpm.
Needs work: * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake) * Spec file: some paths are not replaced with RPM macros (/usr/bin → %{_bindir}) * Source tag should use macros * Some files (CHANGES, README, etc.) should be in %doc
Cleaned up and commited.
Good work at keeping the package clean! I've started the formal review. I see no blockers, only possible improvements. Find here an updated spec file and a patch to the current development one : http://thias.fedorapeople.org/merge-review/byacc/ - Update to the 20070509 release. - Update URL and summary. - Remove useless doc copying in install section. - Add NOTES and NO_WARRANTY docs.
Ping? It would be nice to get this package cleaned up for Fedora 8. Maybe the version update could be skipped because of the feature freeze, though.
I removed the update part, but other than that, I applied the patch unmodified. Thanks. I rebuilt the package: http://koji.fedoraproject.org/koji/taskinfo?taskID=156588 I will push new version post F8.
Great, thanks! I've double checked everything, and it all looks good. Review finished ;-)