Bug 225690 - Merge Review: dhcdbd
Merge Review: dhcdbd
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Chris Lumens
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 13:26 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-06-11 13:21:17 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
clumens: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:26:28 EST
Fedora Merge Review: dhcdbd

http://cvs.fedora.redhat.com/viewcvs/devel/dhcdbd/
Initial Owner: dcantrell@redhat.com
Comment 1 Chris Lumens 2007-06-08 16:56:19 EDT
rpmlint output:
W: dhcdbd macro-in-%changelog post
W: dhcdbd macro-in-%changelog doc
E: dhcdbd no-cleaning-of-buildroot %install

macro usage:
Should Patch0 be specified with %{name}-%{version}-initscript.patch, and the
same for Patch1?

Requires:
Remember that we don't like file requires, so you could just Requires(...)
chkconfig and initscripts.  The guidelines say it's allowed as long as the files
are in /sbin, though.  Your call.

Scriptlets:
Be consistent about checking conditions before running the preun and postun
scriptlets.  Right now, they use different forms of the same test. 
Comment 2 David Cantrell 2007-06-11 13:08:50 EDT
(In reply to comment #1)
> rpmlint output:
> W: dhcdbd macro-in-%changelog post
> W: dhcdbd macro-in-%changelog doc
> E: dhcdbd no-cleaning-of-buildroot %install

Fixed.

> macro usage:
> Should Patch0 be specified with %{name}-%{version}-initscript.patch, and the
> same for Patch1?

I would think so, but someone said %{name}-VERSION is preferred because you want
the patch to indicate the version of the software is was made against.  So while
you may upgrade to version 3.0 of software foo, the patches against 2.5 may
still apply.

> Requires:
> Remember that we don't like file requires, so you could just Requires(...)
> chkconfig and initscripts.  The guidelines say it's allowed as long as the files
> are in /sbin, though.  Your call.

Yeah, I picked those up from the packaging guidelines.  I'll require the
packages though.

Fixed.

> Scriptlets:
> Be consistent about checking conditions before running the preun and postun
> scriptlets.  Right now, they use different forms of the same test. 

Fixed.

Changes made to devel branch.
Comment 3 Chris Lumens 2007-06-11 13:21:17 EDT
Looks good to me.

Note You need to log in before you can comment on or make changes to this bug.