Bug 225692 - Merge Review: dhcpv6
Merge Review: dhcpv6
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Chris Lumens
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 13:26 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-06-12 10:06:45 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
clumens: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:26:42 EST
Fedora Merge Review: dhcpv6

http://cvs.fedora.redhat.com/viewcvs/devel/dhcpv6/
Initial Owner: dcantrell@redhat.com
Comment 1 Chris Lumens 2007-06-11 14:30:22 EDT
W: dhcpv6 prereq-use /sbin/chkconfig, /sbin/service
W: dhcpv6 macro-in-%changelog defattr

%preun and %postun should use the same form of test for whether to run or not.

%attr(750,root,root) %dir %{_localstatedir}/lib/dhcpv6 should use %{name}.

These should use %{_sysconfdir}/sysconfig/... :
%config(noreplace) /etc/sysconfig/dhcp6s
%config(noreplace) /etc/sysconfig/dhcp6r

These should use %{_initrddir}/... :
%attr(755,root,root) %config /etc/rc.d/init.d/dhcp6s
%attr(755,root,root) %config /etc/rc.d/init.d/dhcp6r

You use $RPM_BUILD_ROOT in %clean, but %{buildroot} everywhere else.

The static library needs to be in a dhcpv6-static package.

libdhcp6client-devel needs to Require: pkgconfig, %{name} = %{version}-%{release}.
Comment 2 David Cantrell 2007-06-11 14:55:05 EDT
I fixed the above blockers and spun my changes in to the devel branch.  Check
it, yo.
Comment 3 Chris Lumens 2007-06-11 15:04:16 EDT
You missed using %{name} in the files section for dhcpv6_client, but otherwise
everything else looks okay.

Also, %{_sysconfdir} expands to /etc only, not /etc/sysconfig.  So in the main
%files section, you still need to add sysconfig for the %config lines.
Comment 4 David Cantrell 2007-06-11 15:08:31 EDT
(In reply to comment #3)
> You missed using %{name} in the files section for dhcpv6_client, but otherwise
> everything else looks okay.

Fixed.

> Also, %{_sysconfdir} expands to /etc only, not /etc/sysconfig.  So in the main
> %files section, you still need to add sysconfig for the %config lines.

*sigh*.  Fixed.

Rebuilding.

Note You need to log in before you can comment on or make changes to this bug.