Package Change Request
======================
Package Name: docbook-style-xsl
Updated Fedora Owners: ovasik

Can it be possible to ask "fedora-cvs?" without formal review?

1) rpmlint gave me 
   file-not-utf8 on all files installed /usr/share/doc
you can use iconv to make them utf8 compatible


2)change buildroot to standard acceptable one.
http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473

3)Preserve timestamps
http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d175c4aec8c12868dffb5ab

4) defattr should be %defattr (-,root,root,-)
   I think this should be used.

5) Use macros instead of hard-coded directory names
http://fedoraproject.org/wiki/Packaging/Guidelines#head-255d52ff18f82fa184a32946b82ed81e4fd8885a

source url should use 
Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
as per given in http://fedoraproject.org/wiki/Packaging/SourceURL

I got rpmlint warning about file-not-utf8 only on reference.pdf.gz which is
inside the tarball and I don't think that is good idea to use iconv on it.

Buildroot changed, timestamps preserved, defattr changed, macros used instead of
hard-coded dirs. 

That SourceURL can't be changed to the format you mentioned, because upstream
name is docbook-xsl and fedora name is docbook-style-xsl, therefore I will leave
as it is (with s/prdownloads/downloads, although it is the same)

Are the changes sufficient for you?

those changes will look sufficient but I rechecked and found nearly all files
under /user/share/doc gave me rpmlint warning of utf8.

can you recheck that rpmlint output on noarch rpm?

Ok, no problem ... 
with rpmlint-0.80-3.fc6:

installed package:
$ rpm -q docbook-style-xsl;rpmlint -iv docbook-style-xsl
docbook-style-xsl-1.73.2-3.fc9
I: docbook-style-xsl checking
W: docbook-style-xsl file-not-utf8
/usr/share/doc/docbook-style-xsl-1.73.2/doc/reference.pdf.gz
The character encoding of this file is not UTF-8.  Consider converting it
in the specfile for example using iconv(1).

noarch rpm:
rpmlint -iv docbook-style-xsl-1.73.2-3.fc9.noarch.rpm 
I: docbook-style-xsl checking
W: docbook-style-xsl file-not-utf8
/usr/share/doc/docbook-style-xsl-1.73.2/doc/reference.pdf.gz
The character encoding of this file is not UTF-8.  Consider converting it
in the specfile for example using iconv(1).

Built with requested changes(without UTF-8 conversion of reference.pdf.gz) as
docbook-style-xsl-1.73.2-4.fc9

with latest updates mock build is ok but rpmlint gave me
nearly all files under /usr/share/doc gave me rpmlint warning of utf8.

What kind of information you need? 

Should I approve package with those utf-8 warnings?

With my rpmlint(rpmlint version 0.80 Copyright (C) 1999-2006 Frederic Lepied,
Mandriva) I have only one warning - and this is ok for me - but if your rpmlint
is complaining about all docs, that is wrong. Could you please provide your
rpmlint version and how do you get this warning about all doc files?
I'm using rpmlint -iv <package>.noarch.rpm ...

rpm -qa rpmlint gave me
rpmlint-0.81-1.fc8

My version is rpmlint-0.80-3.fc6 - ok, I will try it with the latest one...

Ok, with rpmlint-0.81-1.fc9 I have a lot of warnings about not UTF-8 ... strange
... will try to fix that ...

I added following section to the prep which silenced all latest rpmlint warning
about non UTF-8. Html files after conversion seems to be readable by web
browser. Do you see something wrong/dangerous in that spec construction?

# fix of non UTF-8 files rpmlint warnings 
for fhtml in $(find ./doc -name '*.html' -type f)
do
iconv -f ISO-8859-1 -t UTF-8 "$fhtml" -o "$fhtml".tmp
mv -f "$fhtml".tmp "$fhtml"
sed -i 's/ISO-8859-1/UTF-8/' "$fhtml"
done

Looks good.
Do you want to build package for me for final review ?

Built as docbook-style-xsl-1.73.2-5.fc9 with small tweak of the html file change
(sed -i 's/charset=ISO-8859-1/charset=UTF-8' "$fhtml") - it is safer - previous
version changed one html file text.

Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM But NOT for RPM.
docbook-style-xsl.noarch: W: file-not-utf8
/usr/share/doc/docbook-style-xsl-1.73.2/doc/reference.pdf.gz
=> these messages can be ignored for this package.
+ source files match upstream.
7dd72a38c7d25e1396fa26b6ee53eae9  docbook-xsl-1.73.2.tar.gz
d41ce59b783b60383cca765902a41039  docbook-xsl-doc-1.73.2.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ package docbook-style-xsl-1.73.2-5.fc9 ->
  Provides: docbook-xsl = 1.73.2
  Requires: docbook-dtd-xml xml-common >= 0.6.3-8
+ Not a GUI app.

APPROVED.

(In reply to comment #16)
> I added following section to the prep which silenced all latest rpmlint warning
> about non UTF-8. Html files after conversion seems to be readable by web
> browser. Do you see something wrong/dangerous in that spec construction?

I think it is wrong. You can do it if you like but the files are
as useful when encoded in latin1. In my opinion this is unuseful 
complexity. Rpmlint should just be ignored in that case.

(I have a different point of view for non utf8 files that don't 
have the encoding advertised in the file. For example README
text files).