Spec URL: https://rajeeshknambiar.fedorapeople.org/spec/rit-keraleeyam-fonts.spec SRPM URL: https://rajeeshknambiar.fedorapeople.org/srpm/rit-keraleeyam-fonts-3.1-0.src.rpm Description: Keraleeyam is a thick san-serif display style font in condensed form for Malayalam traditional script. Fedora Account System Username: rajeeshknambiar
Copr build: https://copr.fedorainfracloud.org/coprs/build/6869126 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257137-rit-keraleeyam-fonts/fedora-rawhide-x86_64/06869126-rit-keraleeyam-fonts/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Created attachment 2007535 [details] The .spec file difference from Copr build 6869126 to 6869157
Copr build: https://copr.fedorainfracloud.org/coprs/build/6869157 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257137-rit-keraleeyam-fonts/fedora-rawhide-x86_64/06869157-rit-keraleeyam-fonts/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9092431 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257137-rit-keraleeyam-fonts/fedora-rawhide-x86_64/09092431-rit-keraleeyam-fonts/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Comments: a) Please update to latest release 3.2.1 b) Please use the build script to build TTF/OTF fonts: https://gitlab.com/rit-fonts/rit-keraleeyam/-/blob/main/build/buildfont.py
Thank you very much for the review! Updated spec and srpm; particularly to use pre-built fonts as per recent communication with RHEL fonts team. SPEC URL: https://rajeeshknambiar.fedorapeople.org/spec/rit-keraleeyam-fonts.spec SRPM URL: https://rajeeshknambiar.fedorapeople.org/srpm/rit-keraleeyam-fonts-3.2.1-0.src.rpm
Created attachment 2092217 [details] The .spec file difference from Copr build 9092431 to 9103636
Copr build: https://copr.fedorainfracloud.org/coprs/build/9103636 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257137-rit-keraleeyam-fonts/fedora-rawhide-x86_64/09103636-rit-keraleeyam-fonts/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks for the update. Is it possible to add fontconfig files? See: https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/#_fontconfig https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/#_fontconfig_3 Some recently orphaned examples that maybe of interest to adopt: https://src.fedoraproject.org/rpms/smc-anjalioldlipi-fonts https://src.fedoraproject.org/rpms/smc-dyuthi-fonts https://src.fedoraproject.org/rpms/smc-raghumalayalamsans-fonts https://src.fedoraproject.org/rpms/smc-suruma-fonts
(In reply to Benson Muite from comment #12) > Thanks for the update. Is it possible to add fontconfig files? > See: > https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/ > #_fontconfig > https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/ > #_fontconfig_3 For Malayalam fonts, we (Fedora) already have serif (RIT-Rachana) and sans-serif (RIT-MeeraNew) specified via appropriate font config. I wasn't sure (also with upstream maintainer hats on) whether these supplementary fonts require fontconfig. But I think, at least generic mapping to 'sans-serif' could be added. I'll add the fontconfig rules upstream and make a point release; then update this review request. > Some recently orphaned examples that maybe of interest to adopt: > https://src.fedoraproject.org/rpms/smc-anjalioldlipi-fonts > https://src.fedoraproject.org/rpms/smc-dyuthi-fonts > https://src.fedoraproject.org/rpms/smc-raghumalayalamsans-fonts > https://src.fedoraproject.org/rpms/smc-suruma-fonts I used to maintain these fonts; but they are obsolete.
New upstream release created with fontconfig. Updated spec and srpm. SPEC URL: https://rajeeshknambiar.fedorapeople.org/spec/rit-keraleeyam-fonts.spec SRPM URL: https://rajeeshknambiar.fedorapeople.org/srpm/rit-keraleeyam-fonts-3.2.2-0.src.rpm
Thanks. Please reference source as indicated at: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags Source: https://gitlab.com/rit-fonts/rit-%{fontfamily}/-/archive/%{version}/rit-%{fontfamily}-%{version}.tar.gz If %setup -qc does not work consider using %autosetup -n rit-%{fontfamily}-%{version}
(In reply to Benson Muite from comment #15) > Thanks. Please reference source as indicated at: > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > #_git_tags > > Source: > https://gitlab.com/rit-fonts/rit-%{fontfamily}/-/archive/%{version}/rit- > %{fontfamily}-%{version}.tar.gz Thank you for the quick review. To clarify again, we're not using the source and build the font in Fedora; but using pre-built font provided by upstream. Unfortunately GitLab (where upstream is hosted) doesn't provide a stable/static URL for the built artifacts. This source URL mechanism is followed in default Malayalam fonts in Fedora: rit-rachana-fonts and rit-meeranew-fonts. Hope this clarifies.
GitLab does seem to provide stable static URL, though may need to indicate expiration date for artifacts https://docs.gitlab.com/ci/jobs/job_artifacts/ Using Source0: %{url}/-/jobs/artifacts/%{version}/download?job=build-tag#/download seems to allow for a download. Fedora does not seem to use the metainfo.xml file, but maybe this is still useful in applications. It is not mentioned in the font packaging guidelines. It does not block the review to install it, but am curious how it is used. The font configuration file https://gitlab.com/rit-fonts/MeeraNew/-/blob/main/meta/65-meera-new-fonts.conf is very good. Can something similar be used for rit-keraleeyam ? As the number 75 for keraleeyam is higher than 65 for meera, if both are installed meera will be chosen as the default, but if only keraleeyam is installed it will be used instead. It is sufficient to apply a patch rather than make a new release.
(In reply to Benson Muite from comment #17) > Source0: %{url}/-/jobs/artifacts/%{version}/download?job=build-tag#/download Only, it doesn't result in a %{name}-%{version}.zip file. curl, which rpmbuild uses, generates a file named 'download'. If only that can be worked around... > Fedora does not seem to use the metainfo.xml file, but maybe this is still > useful > in applications. It is not mentioned in the font packaging guidelines. It > does not > block the review to install it, but am curious how it is used. The metainfo.xml contains AppStream data, consumed by GUI 'app stores' like GNOME Software and Discover to show the font previews. > The font configuration file > https://gitlab.com/rit-fonts/MeeraNew/-/blob/main/meta/65-meera-new-fonts. > conf > is very good. Can something similar be used for rit-keraleeyam ? As the > number > 75 for keraleeyam is higher than 65 for meera, if both are installed meera > will be chosen as the default, but if only keraleeyam is installed it will be > used instead. It is sufficient to apply a patch rather than make a new > release. So, MeeraNew is the default sans-serif font, intended for general use. Keraleeyam, on the other hand is a display typeface (no regular style, only bold) intended for specific typesetting use cases. It shouldn't be used as a general fallback font.
(In reply to Rajeesh from comment #18) > (In reply to Benson Muite from comment #17) > > > Source0: %{url}/-/jobs/artifacts/%{version}/download?job=build-tag#/download > > Only, it doesn't result in a %{name}-%{version}.zip file. curl, which > rpmbuild uses, generates a file named 'download'. If only that can be worked > around... It can. See https://copr.fedorainfracloud.org/coprs/build/9148897 > > > > Fedora does not seem to use the metainfo.xml file, but maybe this is still > > useful > > in applications. It is not mentioned in the font packaging guidelines. It > > does not > > block the review to install it, but am curious how it is used. > > The metainfo.xml contains AppStream data, consumed by GUI 'app stores' like > GNOME Software and Discover to show the font previews. Thanks. Will update font packaging guidelines. Some of the information is the same as in the font configuration file, so maybe tooling can be helpful in reducing maintenance burden. > > > > The font configuration file > > https://gitlab.com/rit-fonts/MeeraNew/-/blob/main/meta/65-meera-new-fonts. > > conf > > is very good. Can something similar be used for rit-keraleeyam ? As the > > number > > 75 for keraleeyam is higher than 65 for meera, if both are installed meera > > will be chosen as the default, but if only keraleeyam is installed it will be > > used instead. It is sufficient to apply a patch rather than make a new > > release. > > So, MeeraNew is the default sans-serif font, intended for general use. > Keraleeyam, on the other hand is a display typeface (no regular style, only > bold) intended for specific typesetting use cases. It shouldn't be used as a > general fallback font. Ok.
(In reply to Benson Muite from comment #19) > (In reply to Rajeesh from comment #18) > > (In reply to Benson Muite from comment #17) > > > > > Source0: %{url}/-/jobs/artifacts/%{version}/download?job=build-tag#/download > > > > Only, it doesn't result in a %{name}-%{version}.zip file. curl, which > > rpmbuild uses, generates a file named 'download'. If only that can be worked > > around... > > It can. See > https://copr.fedorainfracloud.org/coprs/build/9148897 Thank you. Checking the build log indeed shows that the source name is `download`: ... + cd rit-keraleeyam-fonts-3.2.2 + /usr/lib/rpm/rpmuncompress -x /builddir/build/SOURCES/download + STATUS=0 ... How can we manage such unversioned sources in Fedora source repository, especially with `fedpkg new-sources ...`?
fedpkg new-sources will work ok. The hash of the file is computed, so it is possible to track differences.
Figured out a way to get the source from GitLab named to our liking. Updated spec and srpm. SPEC URL: https://rajeeshknambiar.fedorapeople.org/spec/rit-keraleeyam-fonts.spec SRPM URL: https://rajeeshknambiar.fedorapeople.org/srpm/rit-keraleeyam-fonts-3.2.2-1.src.rpm