Bug 225715 - Merge Review: echo-icon-theme
Merge Review: echo-icon-theme
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: David Zeuthen
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 13:31 EST by Nobody's working on this, feel free to take it
Modified: 2013-03-05 22:49 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-04-20 13:05:52 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
bdpepple: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:31:22 EST
Fedora Merge Review: echo-icon-theme

http://cvs.fedora.redhat.com/viewcvs/devel/echo-icon-theme/
Initial Owner: davidz@redhat.com
Comment 1 Brian Pepple 2007-02-04 10:58:34 EST
Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All directories are owned by this or other packages
* Builds fine in mock.

Must Fix:
* Should be Requires(postun), not Requires(postub).
* rpmlint errors:
 W: echo-icon-theme macro-in-%changelog _datadir
 W: echo-icon-theme macro-in-%changelog build
 W: echo-icon-theme macro-in-%changelog buildroot

This should be an easy one to fix.  Just %% the macros in the ChangeLog.
Comment 2 Matthias Clasen 2007-02-05 22:28:19 EST
I've fixed the changelog entries in 0.1-7.fc7
Comment 3 Brian Pepple 2007-02-12 11:42:20 EST
Changes to spec look good.

+1 APPROVE.
Comment 4 Matthias Clasen 2007-04-20 13:05:52 EDT
Lets close this finally.

Note You need to log in before you can comment on or make changes to this bug.