Fedora Merge Review: eel2 http://cvs.fedora.redhat.com/viewcvs/devel/eel2/ Initial Owner: alexl
GOOD: * Package name conforms to the Fedora Naming Guidelines * Group and License tags properly in place * Locales handled correctly * All necessary BuildRequires listed. * Package builds OK in Mock. * Source matches upstream md5sum: dd06a56773af79e4292e63c6bcca9449 eel-2.18.0.1.tar.bz2 NEEDSWORK: * Source url not given in the spec * eel2-devel should not own %{_libdir}/pkgconfig, the -devel %files section should have /usr/lib/pkgconfig/eel-2.0.pc instead * rpmlint warnings: $ rpmlint eel2-2.18.0.1-3.fc7.src.rpm W: eel2 mixed-use-of-spaces-and-tabs (spaces: line 17, tab: line 16) $ rpmlint eel2-2.18.0.1-3.fc7.x86_64.rpm W: eel2 spurious-executable-perm /usr/share/doc/eel2-2.18.0.1/COPYING $ rpmlint eel2-devel-2.18.0.1-3.fc7.x86_64.rpm W: eel2-devel no-documentation (can be ignored!) Minor nit: $RPM_OPT_FLAGS already includes a '-g' option
Fixed in -5
I'm sorry I almost forgot about this. All issues in comment #1 are now fixed; rpmlint is now silent on the srpm and the binaries (except for the ignorable one), and all packaged files are properly owned. APPROVED
Review done.