Bug 225718 - Merge Review: eel2
Merge Review: eel2
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Deji Akingunola
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 13:31 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-08-10 21:37:02 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
dakingun: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:31:49 EST
Fedora Merge Review: eel2

http://cvs.fedora.redhat.com/viewcvs/devel/eel2/
Initial Owner: alexl@redhat.com
Comment 1 Deji Akingunola 2007-04-14 12:26:10 EDT
GOOD:
* Package name conforms to the Fedora Naming Guidelines
* Group and License tags properly in place
* Locales handled correctly
* All necessary BuildRequires listed.
* Package builds OK in Mock.
* Source matches upstream
md5sum: dd06a56773af79e4292e63c6bcca9449  eel-2.18.0.1.tar.bz2

NEEDSWORK:
* Source url not given in the spec
* eel2-devel should not own %{_libdir}/pkgconfig, the -devel %files section
should have /usr/lib/pkgconfig/eel-2.0.pc instead
* rpmlint warnings:
$ rpmlint eel2-2.18.0.1-3.fc7.src.rpm
W: eel2 mixed-use-of-spaces-and-tabs (spaces: line 17, tab: line 16)
$ rpmlint eel2-2.18.0.1-3.fc7.x86_64.rpm
W: eel2 spurious-executable-perm /usr/share/doc/eel2-2.18.0.1/COPYING
$ rpmlint eel2-devel-2.18.0.1-3.fc7.x86_64.rpm
W: eel2-devel no-documentation   (can be ignored!)

Minor nit:
$RPM_OPT_FLAGS already includes a '-g' option

Comment 2 Alexander Larsson 2007-04-23 08:41:43 EDT
Fixed in -5
Comment 3 Deji Akingunola 2007-05-07 00:54:45 EDT
I'm sorry I almost forgot about this.

All issues in comment #1 are now fixed; rpmlint is now silent on the srpm and
the binaries (except for the ignorable one), and all packaged files are properly
owned.

APPROVED
Comment 4 Matthias Clasen 2007-08-10 21:37:02 EDT
Review done.

Note You need to log in before you can comment on or make changes to this bug.