Fedora Merge Review: epiphany http://cvs.fedora.redhat.com/viewcvs/devel/epiphany/ Initial Owner: caillon
rpmlint output: [mclasen@localhost devel]$ rpmlint i386/epiphany- epiphany-2.20.1-4.fc9.i386.rpm epiphany-debuginfo-2.20.1-4.fc9.i386.rpm epiphany-devel-2.20.1-4.fc9.i386.rpm [mclasen@localhost devel]$ rpmlint i386/epiphany-2.20.1-4.fc9.i386.rpm epiphany.i386: W: non-conffile-in-etc /etc/gconf/schemas/epiphany-fonts.schemas epiphany.i386: W: non-conffile-in-etc /etc/gconf/schemas/epiphany-lockdown.schemas epiphany.i386: W: non-conffile-in-etc /etc/gconf/schemas/epiphany-pango.schemas epiphany.i386: W: non-conffile-in-etc /etc/gconf/schemas/epiphany.schemas This is common practise, waived epiphany.i386: W: invalid-license GFDL+ This should be GFDL, I think [mclasen@localhost devel]$ rpmlint i386/epiphany-devel-2.20.1-4.fc9.i386.rpm epiphany-devel.i386: W: no-documentation epiphany-devel.i386: W: invalid-license GFDL+ Ditto package name: ok spec name: ok packaging guidelines: - description should be capitalized - mixture of rm and %{__rm} - -devel should require gtk-doc and pygtk2-devel for directory ownership license: ok license field: see above license file: ok spec file language: ok spec file readable: yes upstream sources: ok buildable: yes excludearch: n/a buildrequires: ok locale handling: ok shared libs: n/a relocatable: n/a directory ownership: see above %files: ok permissions: ok %clean: ok consistent macro use: see above permissible content: ok large docs: n/a %doc content: ok headers: ok static libs: n/a pc files: ok shared libs: n/a devel package: ok libtool archives: ok gui app: ok directory ownership: see above %install: ok utf8 filenames: ok
I've done the remaining cosmetic chances, so the package is ready for approval, methinks. Approved.