Bug 225732 - Merge Review: epiphany
Merge Review: epiphany
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Matthias Clasen
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 13:33 EST by Nobody's working on this, feel free to take it
Modified: 2008-02-06 19:50 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-02-06 19:50:05 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mclasen: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:33:36 EST
Fedora Merge Review: epiphany

http://cvs.fedora.redhat.com/viewcvs/devel/epiphany/
Initial Owner: caillon@redhat.com
Comment 1 Matthias Clasen 2007-11-14 23:33:12 EST
rpmlint output:

[mclasen@localhost devel]$ rpmlint i386/epiphany-
epiphany-2.20.1-4.fc9.i386.rpm
epiphany-debuginfo-2.20.1-4.fc9.i386.rpm
epiphany-devel-2.20.1-4.fc9.i386.rpm
[mclasen@localhost devel]$ rpmlint i386/epiphany-2.20.1-4.fc9.i386.rpm 
epiphany.i386: W: non-conffile-in-etc /etc/gconf/schemas/epiphany-fonts.schemas
epiphany.i386: W: non-conffile-in-etc /etc/gconf/schemas/epiphany-lockdown.schemas
epiphany.i386: W: non-conffile-in-etc /etc/gconf/schemas/epiphany-pango.schemas
epiphany.i386: W: non-conffile-in-etc /etc/gconf/schemas/epiphany.schemas

This is common practise, waived

epiphany.i386: W: invalid-license GFDL+

This should be GFDL, I think


[mclasen@localhost devel]$ rpmlint i386/epiphany-devel-2.20.1-4.fc9.i386.rpm 
epiphany-devel.i386: W: no-documentation
epiphany-devel.i386: W: invalid-license GFDL+

Ditto

package name: ok
spec name: ok
packaging guidelines:
 - description should be capitalized
 - mixture of rm and %{__rm}
 - -devel should require gtk-doc and pygtk2-devel for directory ownership 
license: ok
license field: see above
license file: ok
spec file language: ok
spec file readable: yes
upstream sources: ok
buildable: yes
excludearch: n/a
buildrequires: ok
locale handling: ok
shared libs: n/a
relocatable: n/a
directory ownership: see above
%files: ok
permissions: ok
%clean: ok
consistent macro use: see above
permissible content: ok
large docs: n/a
%doc content: ok
headers: ok
static libs: n/a
pc files: ok
shared libs: n/a
devel package: ok
libtool archives: ok
gui app: ok
directory ownership: see above
%install: ok
utf8 filenames: ok





Comment 2 Matthias Clasen 2008-02-06 19:46:29 EST
I've done the remaining cosmetic chances, so the package is ready for approval,
methinks.

Approved.

Note You need to log in before you can comment on or make changes to this bug.