Bug 225736 - Merge Review: evince
Merge Review: evince
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Kristian Høgsberg
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 13:34 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-08-10 22:43:59 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
bdpepple: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:34:14 EST
Fedora Merge Review: evince

http://cvs.fedora.redhat.com/viewcvs/devel/evince/
Initial Owner: krh@redhat.com
Comment 1 Brian Pepple 2007-02-03 11:20:09 EST
Good:
* Tarball matches upstream
* Source URL is canonical
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* Desktop entry is fine
* All directories are owned by this or other packages
* All necessary BuildRequires listed.
* Post scriptlets conforms to packaging guidelines

Minor:
* You could use the disable-static flag with configure and not even bother with
building the static libs.
* Following rpmlint errors, which can be ignored:
W: evince non-conffile-in-etc /etc/gconf/schemas/evince-thumbnailer.schemas
W: evince non-conffile-in-etc /etc/gconf/schemas/evince.schemas

+1 Approve
Comment 2 Matthias Clasen 2007-08-10 22:43:59 EDT
Review done.

Note You need to log in before you can comment on or make changes to this bug.