Fedora Merge Review: GConf2 http://cvs.fedora.redhat.com/viewcvs/devel/GConf2/ Initial Owner: rstrode
Good: * Source URL is canonical * Upstream source tarball verified * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All directories are owned by this or other packages * All necessary BuildRequires listed. Minor: * Could use the -disable-static config flag, and not even bother building the static libs. * Duplicate BuildRequires: pkgconfig (by libxml2-devel), glib2-devel (by ORBit2-devel), autoconf (by libtool), automake (by libtool), perl-XML-Parser (by intltool) * rpmlint errors (Non-blockers): E: GConf2-devel tag-not-utf8 %changelog W: GConf2-devel no-documentation
I've added --disable-static now, and fixed one gtk-doc related directory ownership problem that you have overlooked.
Review done.