Bug 225812 - Merge Review: gnome-audio
Merge Review: gnome-audio
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Alexander Larsson
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 13:50 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-08-10 16:41:53 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
bdpepple: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:50:41 EST
Fedora Merge Review: gnome-audio

http://cvs.fedora.redhat.com/viewcvs/devel/gnome-audio/
Initial Owner: alexl@redhat.com
Comment 1 Brian Pepple 2007-02-04 12:43:17 EST
Good:
* Source URL is canonical
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* All paths begin with macros
* All directories are owned by this or other packages
* Builds fine in mock.

Must fix:
* rpmlint error: W: gnome-audio hardcoded-path-in-buildroot-tag
/var/tmp/gnome-audio-%{version}-root

Buildroot must be '%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)'.

Minor things to look at, not blockers:
* Might be nice to move the %files section before the ChangeLog.
* rpmlint error: W: gnome-audio summary-ended-with-dot Sounds for GNOME events.
Comment 2 Alexander Larsson 2007-02-05 08:21:09 EST
All comments fixed in cvs (2.0.0-4)
Comment 3 Brian Pepple 2007-02-12 11:45:57 EST
Changes to spec look good.

+1 APPROVE.
Comment 4 Matthias Clasen 2007-08-10 16:41:53 EDT
This review is done.

Note You need to log in before you can comment on or make changes to this bug.