Bug 225820 – Merge Review: gnome-keyring-manager

Bug 225820 - Merge Review: gnome-keyring-manager

Summary:	Merge Review: gnome-keyring-manager

Status:	CLOSED CURRENTRELEASE

Aliases:	None

Product:	Fedora
Classification:	Fedora
Component:	Package Review (Show other bugs)
Sub Component:
Version:	rawhide
Hardware:	All Linux

Priority	medium Severity medium
Target Milestone:	---
Target Release:	---
Assigned To:	Alexander Larsson
QA Contact:	Fedora Package Reviews List
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2007-01-31 13:51 EST by Nobody's working on this, feel free to take it
Modified:	2007-11-30 17:11 EST (History)
CC List:	1 user (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2007-08-10 16:43:52 EDT
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Flags:	dakingun: fedora‑review+

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Groups: None (edit)

Description Nobody's working on this, feel free to take it 2007-01-31 13:51:32 EST

Fedora Merge Review: gnome-keyring-manager

http://cvs.fedora.redhat.com/viewcvs/devel/gnome-keyring-manager/
Initial Owner: alexl@redhat.com

Comment 1 Deji Akingunola 2007-02-08 10:15:12 EST

GOOD:
 * Build Ok in mock (x86_64)
 * License (GPL) and rpm Group tag OK
 * Naming meets the packaging guildlines
 * Spec file clean and legible
 * Handles locales appropriately
 * Buildrequires properly listed
 * rpmlint silent on srpm and a warning that can be ignored on the binary
[deji@agape reviews]$ rpmlint gnome-keyring-manager-2.17.0-1.fc7.x86_64.rpm
W: gnome-keyring-manager non-conffile-in-etc
/etc/gconf/schemas/gnome-keyring-manager.schemas
 * Source file matches upstream
8dc9c133ccdfb2729898a05afa177a0d  gnome-keyring-manager-2.17.0.tar.bz2

 NEEDSWORK:
 * Complete url to the SOURCE is not provided.

APPROVED.

Comment 2 Deji Akingunola 2007-02-08 10:18:53 EST

Re-assigning back to the owner

Comment 3 Matthias Clasen 2007-02-08 15:41:35 EST

* Thu Feb  8 2007 Matthias Clasen <mclasen@redhat.com> - 2.17.0-2
- Package review cleanup

Comment 4 Matthias Clasen 2007-08-10 16:43:52 EDT

This review is done.

Note You need to log in before you can comment on or make changes to this bug.