Bug 225827 - Merge Review: gnome-nettool
Merge Review: gnome-nettool
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Deji Akingunola
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-01-31 13:53 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-08-10 21:40:19 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
dakingun: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:53:06 EST
Fedora Merge Review: gnome-nettool

Initial Owner: caillon@redhat.com
Comment 1 Deji Akingunola 2007-02-09 10:51:23 EST

 * Post and postun requires on desktop-file-utils are not necesary
 * why does it need to run 'update-desktop-database' in it post and postun, the
desktop file deosn't seem to contain any mimetype key (admittedly, I only
checked src/gnome-nettool.desktop.in)
 * The '--add-category X-Red-Hat-Base' can also be removed from the
desktop-file-install, its redundant.
 * Packaging guildelines discourage using the '%makeinstall' macro (see 

Comment 2 Matthias Clasen 2007-02-15 12:07:50 EST
No blockers here, so approved ?
Comment 3 Deji Akingunola 2007-02-16 13:25:02 EST
 * Build Ok in mock (x86_64)
 * License (GPL) and rpm Group tag OK
 * Naming meets the packaging guildlines
 * Handles locales appropriately
 * Buildrequires properly listed
 * rpmlint silent
 * Source file matches upstream
4d73e13da06200fe17c85f616b5e78392  gnome-nettool-2.17.4.tar.bz2

I hope you'll fix the earlier highlighted issues.

Comment 4 Matthias Clasen 2007-08-10 21:40:19 EDT
Review done.

Note You need to log in before you can comment on or make changes to this bug.