Bug 225838 - Merge Review: gnome-system-monitor
Merge Review: gnome-system-monitor
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Matthias Clasen
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 13:55 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-08-10 21:28:44 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
dakingun: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:55:04 EST
Fedora Merge Review: gnome-system-monitor

http://cvs.fedora.redhat.com/viewcvs/devel/gnome-system-monitor/
Initial Owner: sandmann@redhat.com
Comment 1 Deji Akingunola 2007-02-07 16:15:19 EST
Good:
* Package name conforms to the Fedora Naming Guidelines
* Sources, Group and License tags properly in place
* Locales handled correctly
* All necessary BuildRequires listed.
* Package builds OK in Mock.

NEEDSWORK:
According to the packaging guildlines on rpm scriplets,
* The post and postun Requires on desktop-file-utils is not necessary
* call to scrollkeeper-update in post section is inclomplete, should be called like;
 "scrollkeeper-update -q -o %{_datadir}/omf/%{name} || :"
* I believe the "add-category X-Redhat-Base" is no longer necessary for the
desktop file install.

A couple of other minor nitpicks;
* You can pass the "--disable-schemas-install" option to the configure script,
without needing to set and unset the GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL env.
* There are a number of rpmlint warnings/errors which I believe can be ignored;
[deji@agape reviews]$ rpmlint gnome-system-monitor-2.17.6-1.fc7.src.rpm
W: gnome-system-monitor unversioned-explicit-obsoletes gtop
[deji@agape reviews]$ rpmlint gnome-system-monitor-2.17.6-1.fc7.x86_64.rpm
E: gnome-system-monitor obsolete-not-provided gtop
W: gnome-system-monitor no-documentation
W: gnome-system-monitor non-conffile-in-etc
/etc/gconf/schemas/gnome-system-monitor.schemas

 
 
Comment 2 Deji Akingunola 2007-02-08 07:25:46 EST
Another needswork; g-s-monitor use of %makeinstall macro should be changed to
"make DESTDIR=$RPM_BUILD_ROOT install", according to the guildelines @
http://www.fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002
Comment 3 Matthias Clasen 2007-02-08 08:27:37 EST
> * call to scrollkeeper-update in post section is inclomplete, should be called 
>   like; "scrollkeeper-update -q -o %{_datadir}/omf/%{name} || :"

There is no need to slavishly follow the examples in the guidelines to the letter.
The current call works fine
Comment 4 Matthias Clasen 2007-02-08 08:38:07 EST
* The post and postun Requires on desktop-file-utils is not necessary

There is no such requires in my checkout of the spec file ?
Comment 5 Deji Akingunola 2007-02-08 08:46:57 EST
(In reply to comment #4)
> * The post and postun Requires on desktop-file-utils is not necessary
> 
> There is no such requires in my checkout of the spec file ?

Yeah, it's truly not there, i must have confused it with some other package.
Comment 6 Matthias Clasen 2007-02-08 08:58:44 EST
* Thu Feb  8 2007 Matthias Clasen <mclasen@redhat.com> - 2.17.6-2
- Remove an obsolete Obsoletes:
- Don't add X-Redhat-Base to the desktop file anymore

Comment 7 Deji Akingunola 2007-02-08 09:31:40 EST
rpmlint now silent on srpm, and gives warnings (which can be ignored) on the binary
[deji@agape reviews]$ rpmlint gnome-system-monitor-2.17.6-2.fc7.x86_64.rpm
W: gnome-system-monitor no-documentation
W: gnome-system-monitor non-conffile-in-etc
/etc/gconf/schemas/gnome-system-monitor.schemas

APPROVED.
Comment 8 Deji Akingunola 2007-02-08 10:16:45 EST
Sorry, the owner actually have a name.
Comment 9 Matthias Clasen 2007-08-10 21:28:44 EDT
This is done.

Note You need to log in before you can comment on or make changes to this bug.