Fedora Merge Review: grep http://cvs.fedora.redhat.com/viewcvs/devel/grep/ Initial Owner: skasal
* RPM name is OK * Source grep-2.5.1a.tar.bz2 is the same as upstream * This is the latest version * Builds fine in mock Needs work: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * BuildRequires: gzip should not be included (wiki: PackagingGuidelines#Exceptions) * Encoding should be UTF-8 * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake) * The %makeinstall macro should not be used (wiki: PackagingGuidelines#MakeInstall) * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines) * Don't use PreReq for install-info, use Requires(post) and Requires(postun) * Please don't strip symbols from files (LDFLAGS= -s) Rpmlint is not silent: Source RPM: W: grep summary-ended-with-dot The GNU versions of grep pattern matching utilities. E: grep tag-not-utf8 %changelog E: grep non-utf8-spec-file grep.spec W: grep prereq-use /sbin/install-info W: grep make-check-outside-check-section make check W: grep macro-in-%changelog post rpmlint of grep: W: grep summary-ended-with-dot The GNU versions of grep pattern matching utilities. E: grep tag-not-utf8 %changelog
Štěpáne, you shouldn't be ASSIGNed to this bug (see http://fedoraproject.org/wiki/PackageReviewProcess), reviewer should. Ruben, if you have Fedora account, take over this bug please.
Ok, Štěpáne, can you please fix the issues in comment #1?
I apologize for the huge delay. Fixed. I hope I have not missed something.
I don't see any further blockers, so this package is approved.
Thank you for the review!