Bug 225857 - Merge Review: grep
Merge Review: grep
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
urgent Severity medium
: ---
: ---
Assigned To: Ruben Kerkhof
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 13:58 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-04-23 08:33:38 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ruben: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:58:27 EST
Fedora Merge Review: grep

http://cvs.fedora.redhat.com/viewcvs/devel/grep/
Initial Owner: skasal@redhat.com
Comment 1 Ruben Kerkhof 2007-02-03 12:19:48 EST
* RPM name is OK
* Source grep-2.5.1a.tar.bz2 is the same as upstream
* This is the latest version
* Builds fine in mock

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* BuildRequires: gzip should not be included
  (wiki: PackagingGuidelines#Exceptions)
* Encoding should be UTF-8
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* The %makeinstall macro should not be used
  (wiki: PackagingGuidelines#MakeInstall)
* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)
* Don't use PreReq for install-info, use Requires(post) and Requires(postun)
* Please don't strip symbols from files (LDFLAGS= -s)

Rpmlint is not silent:
Source RPM:
W: grep summary-ended-with-dot The GNU versions of grep pattern matching utilities.
E: grep tag-not-utf8 %changelog
E: grep non-utf8-spec-file grep.spec
W: grep prereq-use /sbin/install-info
W: grep make-check-outside-check-section make check
W: grep macro-in-%changelog post

rpmlint of grep:
W: grep summary-ended-with-dot The GNU versions of grep pattern matching utilities.
E: grep tag-not-utf8 %changelog
Comment 2 Matěj Cepl 2007-03-14 17:35:54 EDT
Štěpáne, you shouldn't be ASSIGNed to this bug (see
http://fedoraproject.org/wiki/PackageReviewProcess), reviewer should. Ruben, if
you have Fedora account, take over this bug please.
Comment 3 Ruben Kerkhof 2007-03-15 13:35:36 EDT
Ok,

Štěpáne, can you please fix the issues in comment #1?
Comment 4 Stepan Kasal 2007-04-20 13:50:32 EDT
I apologize for the huge delay.

Fixed.  I hope I have not missed something.
Comment 5 Ruben Kerkhof 2007-04-20 18:20:04 EDT
I don't see any further blockers, so this package is approved.
Comment 6 Stepan Kasal 2007-04-23 08:33:38 EDT
Thank you for the review!

Note You need to log in before you can comment on or make changes to this bug.