Red Hat Bugzilla – Bug 225878
Merge Review: gzip
Last modified: 2007-11-30 17:11:55 EST
Fedora Merge Review: gzip
Initial Owner: firstname.lastname@example.org
I'd be happy to review this package, look for a full review in a bit.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
See below - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
See below - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
See below - Should package latest version
0 open bugs - check for outstanding bugs on package.
1. This version doesn't seem to be available upstream.
There is a 1.3.8 and a 1.3.10. Perhaps upgrading to 1.3.10 should be
the thing to do? Was 1.3.9 removed due to some problem?
2. Buildroot should be the standard one.
Fixed in gzip-1.3.10-1.fc7.
Excellent. Everything looks good from here... this package is APPROVED.
I think the plan is to keep it there open and assigned to you until
it's determined how to import all the approved packages into the new CVS.
Thanks for your prompt response and fixes...
Unsetting fedora-cvs, as Core Merge Reviews are already in CVS, and will be part
of the mass move when we are ready to merge the distro later.
Per the new official review guidelines, I am going to reassign this to me
(the reviewer) and close it rawhide (since the changes are already available