Bug 225907 - Merge Review: iptraf
Merge Review: iptraf
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Marcela Mašláňová
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 14:06 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-08-23 08:03:34 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
dan: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:06:31 EST
Fedora Merge Review: iptraf

http://cvs.fedora.redhat.com/viewcvs/devel/iptraf/
Initial Owner: mmaslano@redhat.com
Comment 1 Dan Horák 2007-02-16 05:46:53 EST
Formal review is here:

OK	source files match upstream:
	    9ee433d95573d612539da4b452e6cdcbca6ab6674a88bfbf6eaf12d4902b5163 
iptraf-3.0.0.tar.gz
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	license field matches the actual license.
OK	license is open source-compatible. License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (i386).
OK	debuginfo package looks complete.
OK	final provides and requires looks sane:
OK	no shared libraries are added to the regular linker search paths.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	no scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
OK	not a GUI app.


MUST FIX:

BAD	build root is NOT correct.
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

BAD	rpmlint is NOT silent.

I: iptraf checking
W: iptraf summary-ended-with-dot A console-based network monitoring utility.

E: iptraf non-standard-dir-perm /var/lock/iptraf 0700
E: iptraf non-standard-dir-perm /var/log/iptraf 0700
E: iptraf non-standard-dir-perm /var/lib/iptraf 0700
	can be ignored

W: iptraf hidden-file-or-dir
/usr/share/doc/iptraf-3.0.0/Documentation/stylesheet-images/.eps
E: iptraf zero-length
/usr/share/doc/iptraf-3.0.0/Documentation/stylesheet-images/.eps
	better will be to delete this file manually, I don't think it is really needed
somewhere
	
W: iptraf log-files-without-logrotate /var/log/iptraf
	maybe a logrotate.d file could be added

I: iptraf checking
W: iptraf summary-ended-with-dot A console-based network monitoring utility.

W: iptraf hardcoded-path-in-buildroot-tag /var/tmp/%{name}-%{version}-root
	see above
Comment 2 Marcela Mašláňová 2007-04-04 10:26:50 EDT
W: iptraf hidden-file-or-dir
It's side effect of making images in Documentation. I can't remove it without
*.gif pictures. It must stay here.

I added logrotate file.
Also other problems were fixed in iptraf-3.0.0-6.
Comment 3 Dan Horák 2007-04-08 07:23:16 EDT
Looks good now, APPROVED

Note You need to log in before you can comment on or make changes to this bug.