Bug 225983 - Merge Review: less
Merge Review: less
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Ivana Varekova
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-01-31 14:18 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-06-20 03:55:12 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ed: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:18:16 EST
Fedora Merge Review: less

Initial Owner: varekova@redhat.com
Comment 1 Ed Hill 2007-02-03 13:37:45 EST
For build, rpmlint, etc. info please see:


 + source matches upstream
 + license is correct

needswork or nits:
 - please remove the trailing '.' from the summary

 - rpmlint reports a few permissions errors:

 - please consider adding %{?dist} to the Release
 - please include the license in %doc since upstream includes it
 - please use the preferred BuildRoot
 - please use %defattr(-,root,root,-)
Comment 2 Ivana Varekova 2007-02-08 04:03:49 EST
All problems except of permission problem - which is reported by  rpmlint are
fixed in less-394-7.fc7. It is a problem to change permissions in cvs so the
best solution I see is to leave them as they are.
Comment 3 Robert Scheck 2007-02-18 17:40:45 EST
/etc/profile.d/less.{sh,csh} is 755, but should be 644:

E: less executable-sourced-script /etc/profile.d/less.sh 0755
E: less world-writable /usr/share/doc/less-394/LICENSE 0666
E: less executable-sourced-script /etc/profile.d/less.csh 0755
Comment 4 Ivana Varekova 2007-02-19 06:34:25 EST
Thanks for your comment.
/etc/profile.d/less.{sh,csh} has the right permissions - rpmlint should not
display it as an error, the only problem was /usr/share/doc/less-394/LICENSE
permissions which are fixed in less-394-8.fc7.
Comment 5 Ville Skyttä 2007-02-19 14:03:19 EST
Why would executable bits for /etc/profile.d/*sh scripts be correct?  They do
not have a shebang, so they cannot be executed alone, and /etc/bashrc and
/etc/csh.cshrc check for them using -r (readability, not executability), then
source (not execute) them.

Some 5+ years ago it was necessary to have them executable because of bugs in
the setup package, but that has been fixed since around Red Hat Linux 7.1, see
bug 35714.  644 should be the correct permissions for them these days.

Having them with incorrect permissions in CVS is an orthogonal issue which
shouldn't prevent them from being shipped with correct permissions in the actual
Comment 6 Ivana Varekova 2007-02-20 04:07:04 EST
Thanks. You are right permmissions are changed in less-394-9.fc7.
Comment 7 Ivana Varekova 2007-04-05 04:08:38 EDT
could you please look at less-394-9.fc7 and approved this review request or
if you see any reason why you wdon't want to aproved it here. 
Comment 8 Ed Hill 2007-04-17 22:37:06 EDT
My apologies for taking so long to get back to this!  All issues are fixed 
in less-394-9.fc7.  APPROVED.

Note You need to log in before you can comment on or make changes to this bug.