Fedora Merge Review: libdv http://cvs.fedora.redhat.com/viewcvs/devel/libdv/ Initial Owner: jwilson
Please find an updated spec file and a patch to the current spec file containing some suggested changes and fixes : http://thias.fedorapeople.org/merge-review/libdv/ - Update License field. - Remove useless zero epoch. - Add pkgconfig devel sub-package requirement. The package was already quite clean overall :-)
Ping? It would be nice to get this package cleaned up for Fedora 8.
libdv-1.0.0-2.fc8 built with all suggested updates and a few other minor spec tweaks of my own.
Yeah, kill the tabs! :-) One more minor change I forgot : The man pages in %files aren't listed consistently, or even right. They should all be foo.1* with no foo.1.gz since the compression used is an rpm build time option. I also just double checked a rebuild, and it seems that this package got affected by the recent rpm/popt split : checking for poptGetContext in -lpopt... no configure: WARNING: playdv needs the popt package for command line parsing. The source archive for popt is available at: ftp://ftp.redhat.com/pub/redhat/code/popt So you need to add "BuildRequires: popt-devel". Apart from this, the package looks good.
Okay, files list fixed up, as well as BR: on popt-devel, conditional on fedora >= 8 added. Good catch on the popt-devel, I've mostly had my head in the sand wrt fedora the past month or so focused on rhel5.1 work, had no clue there'd been a change there.
(OT: Good to know, I'm impatient for RHEL5.1 to come out :-)) Thanks for fixing so quickly, review finished!