Good:
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* All paths begin with macros
* All necessary BuildRequires listed.
* Package builds in Mock.

Must Fix:
* The devel package require should be:
Requires: libvorbis = %{epoch}:%{version}-%{release}
* Should use BuildRequires, instead of BuildPrereq for libogg
* rpmlint gives the following error:
 E: libvorbis-devel obsolete-not-provided vorbis-devel
* Is the static lib necessary?  If so, it should be split out into a
sub-package.  Refer to:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7

Minor:
* Doesn't use preferred buildroot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* Drop the '.' from the summary to quite rpmlint.
* Does this package build using 'make %{_smp_mflags}'?
* rpmlint warnings:
 W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/floor1_inverse_dB_table.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/framing.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/v-comment.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/helper.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/vorbis-fidelity.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/stereo.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/programming.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/oggstream.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/vorbisfile/fileinfo.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/vorbis.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/index.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/vorbisfile/seeking.html

* Thu Feb  8 2007 Matthias Clasen <mclasen> - 1:1.1.2-2
- Package review cleanups
- Don't ship static libraries

Brian, anything left here ?

Nope, you changes look fine.

Review done.