Bug 226056 - Merge Review: libvorbis
Merge Review: libvorbis
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Matthias Clasen
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 14:28 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-08-10 21:30:04 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
bdpepple: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:28:44 EST
Fedora Merge Review: libvorbis

http://cvs.fedora.redhat.com/viewcvs/devel/libvorbis/
Initial Owner: besfahbo@redhat.com
Comment 1 Brian Pepple 2007-02-03 14:26:10 EST
Good:
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* All paths begin with macros
* All necessary BuildRequires listed.
* Package builds in Mock.

Must Fix:
* The devel package require should be:
Requires: libvorbis = %{epoch}:%{version}-%{release}
* Should use BuildRequires, instead of BuildPrereq for libogg
* rpmlint gives the following error:
 E: libvorbis-devel obsolete-not-provided vorbis-devel
* Is the static lib necessary?  If so, it should be split out into a
sub-package.  Refer to:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7

Minor:
* Doesn't use preferred buildroot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* Drop the '.' from the summary to quite rpmlint.
* Does this package build using 'make %{_smp_mflags}'?
* rpmlint warnings:
 W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/floor1_inverse_dB_table.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/framing.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/v-comment.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/helper.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/vorbis-fidelity.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/stereo.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/programming.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/oggstream.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/vorbisfile/fileinfo.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/vorbis.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/index.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/vorbisfile/seeking.html
Comment 2 Matthias Clasen 2007-02-08 12:12:56 EST
* Thu Feb  8 2007 Matthias Clasen <mclasen@redhat.com> - 1:1.1.2-2
- Package review cleanups
- Don't ship static libraries
Comment 3 Matthias Clasen 2007-04-11 07:14:09 EDT
Brian, anything left here ?
Comment 4 Brian Pepple 2007-04-11 13:17:38 EDT
Nope, you changes look fine.
Comment 5 Matthias Clasen 2007-08-10 21:30:04 EDT
Review done.

Note You need to log in before you can comment on or make changes to this bug.