Bug 226081 - Merge Review: libXpm
Summary: Merge Review: libXpm
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-01-31 19:31 UTC by Nobody's working on this, feel free to take it
Modified: 2008-01-15 05:06 UTC (History)
2 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2008-01-15 05:06:04 UTC
panemade: fedora-review+


Attachments (Terms of Use)

Description Nobody's working on this, feel free to take it 2007-01-31 19:31:56 UTC
Fedora Merge Review: libXpm

http://cvs.fedora.redhat.com/viewcvs/devel/libXpm/
Initial Owner: sandmann@redhat.com

Comment 1 Parag AN(पराग) 2008-01-15 05:06:04 UTC
Review:
+ package builds in mock (rawhide i386).
+ rpmlint output is Silent.
+ source match upstream
cd15ee542d9f515538b4462a6f79d977  libXpm-3.5.7.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are used correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains contents.
+ no static libraries.
+ xpm.pc file present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ ldconfig scriptlets are used.
+ Not a GUI app.

APPROVED.



Note You need to log in before you can comment on or make changes to this bug.