Fedora Merge Review: libXpm http://cvs.fedora.redhat.com/viewcvs/devel/libXpm/ Initial Owner: sandmann
Review: + package builds in mock (rawhide i386). + rpmlint output is Silent. + source match upstream cd15ee542d9f515538b4462a6f79d977 libXpm-3.5.7.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains contents. + no static libraries. + xpm.pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + ldconfig scriptlets are used. + Not a GUI app. APPROVED.