Fedora Merge Review: libXp http://cvs.fedora.redhat.com/viewcvs/devel/libXp/ Initial Owner: sandmann
Review: + package builds in mock (rawhide i386). + rpmlint output is ok to accept libXp.src:63: W: rpm-buildroot-usage %build CPPFLAGS="$CPPFLAGS -I$RPM_BUILD_ROOT%{_includedir}" as this is side effect of patch + source match upstream 0f4ac39108c1ae8c443cdfac259b58fa libXp-1.0.0.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains contents. + no static libraries. + xp.pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + ldconfig scriptlets are used. + Not a GUI app. APPROVED.