Fedora Merge Review: libXp
Initial Owner: firstname.lastname@example.org
+ package builds in mock (rawhide i386).
+ rpmlint output is ok to accept
libXp.src:63: W: rpm-buildroot-usage %build CPPFLAGS="$CPPFLAGS
as this is side effect of patch
+ source match upstream
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are used correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains contents.
+ no static libraries.
+ xp.pc file present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ ldconfig scriptlets are used.
+ Not a GUI app.