* RPM name is OK
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* Spec file: some paths are not replaced with RPM macros
  (wiki: QAChecklist item 7)
* No downloadable source. Please give the full URL in the Source tag.
* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)

Notes:
* There's no need to add -g to RPM_OPT_FLAGS, it's included by default
* Use DESTDIR instead of PREFIX in %install
* Preserve timestamps with install -p in %install
* Is it necessary to create the empty logrotate.status?

Rpmlint output:
rpmlint of logrotate-3.7.4-11.fc6.i386.rpm:W: logrotate no-url-tag
E: logrotate zero-length /var/lib/logrotate.status

>No downloadable source. Please give the full URL in the Source tag.
There isn't any URL you can download sources from. RH is upstream for 
logrotate.

> Use DESTDIR instead of PREFIX in %install
I can't use DESTDIR, since there isn't standart Makefile in logrotate.

> Is it necessary to create the empty logrotate.status?
bz #55809

see: logrotate-3.7.4-12.fc7

>> No downloadable source. Please give the full URL in the Source tag.
> There isn't any URL you can download sources from. RH is upstream for logrotate.

Agreed.

>> Use DESTDIR instead of PREFIX in %install
> I can't use DESTDIR, since there isn't standart Makefile in logrotate.

Ok.

>> Is it necessary to create the empty logrotate.status?
> bz #55809

Ok, I'm not sure this is a bug, but is doesn't do any harm either.

One thing left: you haven't converted all paths to macro's
There's /etc in %install, replace that with %{_sysconfdir}
Replace /var with %{_localstatedir}

Thanks,

Ruben

fixed in logrotate-3.7.4-13.fc7

Thanks.

I don't see any blockers, so this package is approved.