Bug 226104 - Merge Review: logrotate
Merge Review: logrotate
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Ruben Kerkhof
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 14:34 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-06-20 03:56:22 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ruben: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:34:54 EST
Fedora Merge Review: logrotate

http://cvs.fedora.redhat.com/viewcvs/devel/logrotate/
Initial Owner: pvrabec@redhat.com
Comment 1 Ruben Kerkhof 2007-02-03 17:28:10 EST
* RPM name is OK
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* Spec file: some paths are not replaced with RPM macros
  (wiki: QAChecklist item 7)
* No downloadable source. Please give the full URL in the Source tag.
* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)

Notes:
* There's no need to add -g to RPM_OPT_FLAGS, it's included by default
* Use DESTDIR instead of PREFIX in %install
* Preserve timestamps with install -p in %install
* Is it necessary to create the empty logrotate.status?

Rpmlint output:
rpmlint of logrotate-3.7.4-11.fc6.i386.rpm:W: logrotate no-url-tag
E: logrotate zero-length /var/lib/logrotate.status
Comment 2 Peter Vrabec 2007-02-08 11:12:58 EST
>No downloadable source. Please give the full URL in the Source tag.
There isn't any URL you can download sources from. RH is upstream for 
logrotate.

> Use DESTDIR instead of PREFIX in %install
I can't use DESTDIR, since there isn't standart Makefile in logrotate.

> Is it necessary to create the empty logrotate.status?
bz #55809

see: logrotate-3.7.4-12.fc7
Comment 3 Ruben Kerkhof 2007-02-08 16:25:48 EST
>> No downloadable source. Please give the full URL in the Source tag.
> There isn't any URL you can download sources from. RH is upstream for logrotate.

Agreed.

>> Use DESTDIR instead of PREFIX in %install
> I can't use DESTDIR, since there isn't standart Makefile in logrotate.

Ok.

>> Is it necessary to create the empty logrotate.status?
> bz #55809

Ok, I'm not sure this is a bug, but is doesn't do any harm either.

One thing left: you haven't converted all paths to macro's
There's /etc in %install, replace that with %{_sysconfdir}
Replace /var with %{_localstatedir}

Thanks,

Ruben
Comment 4 Peter Vrabec 2007-02-09 05:25:38 EST
fixed in logrotate-3.7.4-13.fc7
Comment 5 Ruben Kerkhof 2007-02-10 06:41:48 EST
Thanks.

I don't see any blockers, so this package is approved.

Note You need to log in before you can comment on or make changes to this bug.