Bug 226182 - Merge Review: nasm
Merge Review: nasm
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-01-31 15:14 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
2 users (show)

See Also:
Fixed In Version: 0.98.39-5.fc7
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-05-05 13:06:21 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:14:46 EST
Fedora Merge Review: nasm

Initial Owner: pmachata@redhat.com
Comment 1 Jason Tibbitts 2007-02-03 15:08:53 EST
Some rpmlint complaints:
   E: nasm non-utf8-spec-file nasm.spec
   E: nasm-debuginfo tag-not-utf8 %changelog
   E: nasm-doc tag-not-utf8 %changelog
   E: nasm tag-not-utf8 %changelog
   E: nasm-rdoff tag-not-utf8 %changelog
   E: nasm tag-not-utf8 %changelog
These are all due to Trond's name in the changelog; it would probably be
best to run the entire changelog through iconv to get rid of these.

   W: nasm-doc summary-ended-with-dot Documentation for NASM.
   W: nasm summary-ended-with-dot A portable x86 assembler which uses Intel-like syntax.
   W: nasm-rdoff summary-ended-with-dot Tools for the RDOFF binary format, sometimes used with NASM.
   W: nasm summary-ended-with-dot A portable x86 assembler which uses Intel-like syntax.
Trivial to clean these up.

   W: nasm prereq-use /sbin/install-info
Use this instead:
Requires(post): /sbin/install-info
Requires(preun): /sbin/install-info

   W: nasm setup-not-quiet
Not a big deal, but you can pass "-q" on the %setup line to quiet it.

   W: nasm patch-not-applied Patch0: nasm-0.98-boguself2.patch
If this patch isn't needed, it should probably just be removed.

   W: nasm-rdoff no-documentation
This is OK.

The only other issue I see is the BuildRoot:.

* source files match upstream:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
X build root is not correct; should be:
  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  Whether this is absolutely mandatory depends on a decision by FESCo, which
  should happen over the weekend.
* license field matches the actual license.
*  license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper (BR: perl is unnecessary)
* compiler flags are appropriate.
* %clean is present.
* package builds in mock.
* debuginfo package looks complete.
X rpmlint is silent.
* final provides and requires are sane:
   nasm = 0.98.39-4.fc7
  (other packages have only basic dependencies)
O %check is not present; there does seem to be something resembling a test
    suite in the source, but I'm not sure if it's feasible to run it at build
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is in a -doc subpackage.
* %docs are not necessary for the proper functioning of the package.
*  no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
Comment 2 Jason Tibbitts 2007-02-03 18:28:58 EST
Just a note:

I did attempt to build this package with "make DESTDIR=.. install" instead of
%makeinstall and it failed to build with the usual permission failures as it
tries to write outside of the buildroot.  So %makeinstall seems to be required here.
Comment 3 Petr Machata 2007-02-07 14:02:39 EST
Tidied up version commited, not built.
rpmlint is silent, for both source and binary rpm.
Comment 4 Jason Tibbitts 2007-02-23 11:31:01 EST
Drat, assignment pingponging caused this to drop completely off of my list. 
I'll get back to this today.
Comment 5 Jason Tibbitts 2007-02-23 19:48:40 EST
OK, buildroot is good, rpmlint is quiet except for the single line
   W: nasm-rdoff no-documentation
which is not a problem.  So we're good to go.


Go ahead and close this bug when the package has made it into rawhide.
Comment 6 Jason Tibbitts 2007-05-05 13:06:21 EDT
It looks like this is in rawhide now, so this bug should be closed.  I'll go
ahead and do that.

Note You need to log in before you can comment on or make changes to this bug.