This service will be undergoing maintenance at 00:00 UTC, 2016-09-28. It is expected to last about 1 hours
Bug 226224 - Merge Review: pam_ccreds
Merge Review: pam_ccreds
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Marcela Mašláňová
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 15:19 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version: F7
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-08-24 02:55:54 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
mmaslano: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:19:42 EST
Fedora Merge Review: pam_ccreds

http://cvs.fedora.redhat.com/viewcvs/devel/pam_ccreds/
Initial Owner: tmraz@redhat.com
Comment 1 Marcela Mašláňová 2007-03-29 06:41:07 EDT
W: pam_ccreds no-url-tag
E: pam_ccreds binary-or-shlib-defines-rpath /usr/sbin/ccreds_validate
['/lib/security']
E: pam_ccreds binary-or-shlib-defines-rpath /usr/sbin/cc_dump ['/lib/security']
E: pam_ccreds binary-or-shlib-defines-rpath /usr/sbin/cc_test ['/lib/security']
-> replace rpath if possible
E: pam_ccreds setuid-binary /usr/sbin/ccreds_validate root 04755
E: pam_ccreds non-standard-executable-perm /usr/sbin/ccreds_validate 04755
-> I think they are needed for functionality of pam_ccred
W: pam_ccreds buildprereq-use automake db4-devel openssl-devel pam-devel
-> Use plain BuildRequires instead.

Missing dist tag.
Missing post, pre part with ldconfig for shared library.
Requires should include version, which is needed for install/build
%{name} >= %{version}-%{release}
Comment 2 Tomas Mraz 2007-04-05 07:04:37 EDT
(In reply to comment #1)
> W: pam_ccreds no-url-tag
Fixed.
> E: pam_ccreds binary-or-shlib-defines-rpath /usr/sbin/ccreds_validate
> ['/lib/security']
> E: pam_ccreds binary-or-shlib-defines-rpath /usr/sbin/cc_dump ['/lib/security']
> E: pam_ccreds binary-or-shlib-defines-rpath /usr/sbin/cc_test ['/lib/security']
> -> replace rpath if possible
No, the rpath is correct because the binaries have to link to the pam_ccreds.so
module directly.

> E: pam_ccreds setuid-binary /usr/sbin/ccreds_validate root 04755
> E: pam_ccreds non-standard-executable-perm /usr/sbin/ccreds_validate 04755
> -> I think they are needed for functionality of pam_ccred
Yes.

> W: pam_ccreds buildprereq-use automake db4-devel openssl-devel pam-devel
> -> Use plain BuildRequires instead.
Fixed.

> Missing dist tag.
Added.

> Missing post, pre part with ldconfig for shared library.
There is only pam module, no regular shared library -> no need for ldconfig.

> Requires should include version, which is needed for install/build
> %{name} >= %{version}-%{release}
It should build fine with versions which are not years old I don't think
explicit versions are required.

(pam_ccreds-4-2.fc7)

Note You need to log in before you can comment on or make changes to this bug.