Fedora Merge Review: patch http://cvs.fedora.redhat.com/viewcvs/devel/patch/ Initial Owner: twaugh
rpmlint output => patch.src: I: checking patch.src: E: non-utf8-spec-file /tmp/patch-2.5.4-30.fc8.src.rpm.6404/patch.spec The character encoding of the spec file is not UTF-8. Convert it for example using iconv(1). patch.src: W: patch-not-applied Patch8: patch-selinux.patch A patch is included in your package but was not applied. Refer to the patches documentation to see what's wrong. patch.src: E: tag-not-utf8 %changelog The character encoding of the value of this tag is not UTF-8. Also, 1)use macros under %files section check =>http://fedoraproject.org/wiki/Packaging/RPMMacros 2) use of parallel make check => http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b759c65c35c82bf434d2e 3) avoid makeinstall usage =>http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002 4)Good to have defattr used as %defattr(-,root,root,-)
Spec file converted to UTF-8. patch-selinux.patch is a work in progress and so is not yet applied -- this is intentional. %files section now uses %{_bindir} instead of /usr/bin smp_mflags now used defattr fixed We use %makeinstall in the patch package because the tarball has no support for DESTDIR. New package: patch-2.5.4-31.fc9
do you want to use patch-selinux patch or can you comment it? rpmlint gave me patch.src: W: patch-not-applied Patch8: patch-selinux.patch A patch is included in your package but was not applied. Refer to the patches documentation to see what's wrong.
The patch is not yet complete and so is deliberately not applied.
with new updated release packaging looks ok then. APPROVED.