Fedora Merge Review: patchutils
Initial Owner: email@example.com
rpmlint gave me ->
patchutils.src:11: W: unversioned-explicit-obsoletes interdiff
The specfile contains an unversioned Obsoletes: token, which will match all
older, equal and newer versions of the obsoleted thing. This may cause update
problems, restrict future package/provides naming, and may match something it
was originally not inteded to match -- make the Obsoletes versioned if
patchutils.src:12: W: unversioned-explicit-provides interdiff
The specfile contains an unversioned Provides: token, which will match all
older, equal, and newer versions of the provided thing. This may cause
update problems and will make versioned dependencies, obsoletions and conflicts
on the provided thing useless -- make the Provides versioned if possible.
patchutils.src:32: W: make-check-outside-check-section make check
Make check or other automated regression test should be run in %check, as
they can be disabled with a rpm macro for short circuiting purposes.
1) use of parallel make check =>
2) avoid makeinstall usage
3)Good to have defattr used as %defattr(-,root,root,-)
other thing man pages timestamps are changing and not following what upstream
released with timestamps.
The man pages are deliberately rebuilt so that they are consistent with any
other xmlto-built man pages on the system.
Other fixes applied.
New package: patchutils-0.2.31-4.fc9
with new updated release packaging looks ok then.