Fedora Merge Review: perl-Digest-HMAC
Initial Owner: firstname.lastname@example.org
1)perl as BR is not needed. mock build without it worked successfully.
remove redundant dependency on perl >= 1:5.6.1
2)you may like to use disttag
3)rpmlint only complained ->
perl-Digest-HMAC.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 3)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance. Use either spaces or tabs for indentation, not both.
==>Use "sed -i -e 's|\t| |g' perl-Digest-HMAC.spec"
new version is perl-Digest-HMAC-1.01-17.fc9
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
All tests successful.
Files=1, Tests=14, 0 wallclock secs ( 0.02 cusr + 0.00 csys = 0.02 CPU)
+ Package perl-Digest-HMAC-1.01-17.fc8 ->
Provides: perl(Digest::HMAC) = 1.01 perl(Digest::HMAC_MD5) perl(Digest::HMAC_SHA1)
Requires: perl(:MODULE_COMPAT_5.8.8) perl(Digest::HMAC) perl(Digest::MD5)
perl(Digest::SHA1) perl(Exporter) perl(strict) perl(vars)
Can we CLOSE this review if package is already built and in rawhide?