Fedora Merge Review: perl-IO-Socket-INET6 http://cvs.fedora.redhat.com/viewcvs/devel/perl-IO-Socket-INET6/ Initial Owner: wtogami
1)perl as BR is not needed. mock build without it worked successfully. remove redundant dependency on perl 2)you may like to keep simple disttag as "2%{dist}" only. 3) Add Changelog as %doc
don't hard code version in source URL
Warren, Can you please update SPEC and build package?
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url e4ef8b7944fa036cda19dc3e1cc688a6 IO-Socket-INET6-2.51.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package perl-IO-Socket-INET6-2.51-3.fc9 -> Provides: perl(IO::Socket::INET6) = 2.51 Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Errno) perl(Exporter) perl(IO::Socket) perl(Socket) perl(Socket6) perl(strict) APPROVED.