Bug 226334 - Merge Review: pykickstart
Merge Review: pykickstart
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: David Cantrell
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-01-31 15:45 EST by Nobody's working on this, feel free to take it
Modified: 2009-09-21 16:17 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-06-11 13:22:38 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
dcantrell: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:45:26 EST
Fedora Merge Review: pykickstart

Initial Owner: clumens@redhat.com
Comment 1 David Cantrell 2007-06-08 16:15:55 EDT
Initial rpmlint run:

W: pykickstart macro-in-%changelog ksappend
Comment 2 David Cantrell 2007-06-08 16:22:38 EDT
The following:
%{!?python_sitelib: %define python_sitelib %(python -c "from distutils.sysconfig
import get_python_lib; print get_python_lib()")}

Should be:
%{!?python_sitelib: %define python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib()")}
Comment 3 David Cantrell 2007-06-08 16:24:33 EDT
The Source0 field should contain the URL to the downloadable source or a comment
like this above it:

# This is a Red Hat maintained package which is specific to
# our distribution.  Thus the source is only available from
# within this srpm.
Comment 4 Chris Lumens 2007-06-08 17:15:28 EDT
Not going to fix the rpmlint warning because pykickstart is special, and that
refers to the %ksappend section in the file format.  The other two are fixed in
Comment 5 David Cantrell 2007-06-11 13:22:38 EDT
Sounds good to me.  Closing.
Comment 6 Jason Tibbitts 2007-06-20 12:54:49 EDT
Hmm, fedora-review is still set to '?'.  If this was approved, could someone
(preferrably the person who approved it) set it to '+'?

Note You need to log in before you can comment on or make changes to this bug.