Fedora Merge Review: pykickstart http://cvs.fedora.redhat.com/viewcvs/devel/pykickstart/ Initial Owner: clumens
Initial rpmlint run: W: pykickstart macro-in-%changelog ksappend
The following: %{!?python_sitelib: %define python_sitelib %(python -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} Should be: %{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")}
The Source0 field should contain the URL to the downloadable source or a comment like this above it: # This is a Red Hat maintained package which is specific to # our distribution. Thus the source is only available from # within this srpm.
Not going to fix the rpmlint warning because pykickstart is special, and that refers to the %ksappend section in the file format. The other two are fixed in 1.2-2.
Sounds good to me. Closing.
Hmm, fedora-review is still set to '?'. If this was approved, could someone (preferrably the person who approved it) set it to '+'?