Bug 226351 - Merge Review: qt
Merge Review: qt
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Rex Dieter
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 15:47 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-06-20 10:32:04 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
rdieter: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:47:34 EST
Fedora Merge Review: qt

http://cvs.fedora.redhat.com/viewcvs/devel/qt/
Initial Owner: than@redhat.com
Comment 1 Rex Dieter 2007-02-07 12:34:54 EST
Guidelines-wise, looks good, only a few relatively small SHOULD (optional) items
to consider:

* icons.  SHOULD try to follow icon-spec here, and put items in/under
%_datadir/icons/hicolor/ somewhere instead of using %_datadir/pixmaps

* .desktop files: using namespace/vendor of qt-* *and* using '3' appended to
.desktop file names is redundant.  Consider removing the '3' from the .desktop
file names.

* consider changing qtdir from %{_libdir}/qt-3.3 to just %_libdir/qt3.  It would
then be consistent with qt4 packaging.  This is a big change that may induce
pain in other packages that currently hard-code the old location, so it may not
be worth it.

* -devel-docs subpkg SHOULD:
  1. should simply be -doc (corrolary: and have no dependency on -devel)
  2. assistant should be included here.

* SHOULD avoid some of the multilib ickiness, and necessity to use
/etc/ld.so.conf.d/qt*, by simply using
./configure -libdir %{_libdir}
ie, putting qt's libs into %_libdir directly.

qt4 has been using these latter 2 items with success.
Comment 2 Gianluca Sforna 2007-02-07 17:41:32 EST
(In reply to comment #1)
> * -devel-docs subpkg SHOULD:
>   1. should simply be -doc (corrolary: and have no dependency on -devel)
>   2. assistant should be included here.
> 
I think this would break designer Help->Manual menu
Comment 3 Rex Dieter 2007-02-08 09:07:13 EST
> I think this would break designer Help->Manual menu
How so?  It would be no less broken than the current situation (or when
qt-devel-docs wasn't installed).
Comment 4 Rex Dieter 2007-02-12 11:42:30 EST
Considering there are no MUST blockers, I'll mark qt as approved.

We can address the SHOULD items post-merge-review.
Comment 5 Rex Dieter 2007-06-20 10:32:04 EDT
good to go, closing...

Note You need to log in before you can comment on or make changes to this bug.