Bug 226400 - Merge Review: screen
Merge Review: screen
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Marcela Mašláňová
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 15:56 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-02-06 07:16:55 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ed: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:56:18 EST
Fedora Merge Review: screen

http://cvs.fedora.redhat.com/viewcvs/devel/screen/
Initial Owner: mmaslano@redhat.com
Comment 1 Ed Hill 2007-02-03 17:18:58 EST
Hi folks, here's a quick review:

good:
 + source matches upstream  (where "upstream" 
   apparently == Juergen, not savannah.gnu.org)
 + license is GPL v2 -- OK
 + BuildRoot OK
 + scriptlets OK
 + dir ownership looks OK

needswork:
 - since upstream includes a copy of the license, please 
   include it in %doc

 - please list the license as "GPL", not "GPL2"

rpmlint:
 - rpmlint whines about a few things (the permissions 
   appear to be OK to ignore since screen needs them):
http://linux.dell.com/files/fedora/FixBuildRequires/mock-results-core/i386/screen-4.0.3-2.fc7.src.rpm/result/rpmlint.log


Please make the two tiny changes above and this package is APPROVED.
Comment 2 Marcela Mašláňová 2007-02-06 07:16:55 EST
Thank you for your review.

Note You need to log in before you can comment on or make changes to this bug.