This service will be undergoing maintenance at 00:00 UTC, 2017-10-23 It is expected to last about 30 minutes
Bug 226459 - Merge Review: system-config-kickstart
Merge Review: system-config-kickstart
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: David Cantrell
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 16:05 EST by Nobody's working on this, feel free to take it
Modified: 2009-09-21 16:17 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-06-12 15:43:13 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
dcantrell: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 16:05:39 EST
Fedora Merge Review: system-config-kickstart

http://cvs.fedora.redhat.com/viewcvs/devel/system-config-kickstart/
Initial Owner: clumens@redhat.com
Comment 1 David Cantrell 2007-06-11 14:36:04 EDT
W: system-config-kickstart summary-ended-with-dot A graphical interface for
making kickstart files.
E: system-config-kickstart tag-not-utf8 %changelog
E: system-config-kickstart non-utf8-spec-file system-config-kickstart.spec
W: system-config-kickstart unversioned-explicit-obsoletes ksconfig
W: system-config-kickstart unversioned-explicit-obsoletes redhat-config-kickstart
W: system-config-kickstart macro-in-%changelog packages
W: system-config-kickstart macro-in-%changelog doc
W: system-config-kickstart no-%build-section

The Source0 field should contain the URL to the downloadable source or a comment
like this above it:

# This is a Red Hat maintained package which is specific to
# our distribution.  Thus the source is only available from
# within this srpm.

BuildRoot should be:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Personal opinion: group Obsoletes, BuildRequires, and Requires items on to a
smaller number of lines?

%{buildroot} vs. $RPM_BUILD_ROOT

Line 17 has a trailing space.

In %files, use %defattr(-,root,root,-)

Use path macros in %files section.

Make sure desktop-file-install usage is per the guidelines:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-d559ee7363418a5840ce63090c608c991cd39ce6
Comment 2 Chris Lumens 2007-06-11 15:21:57 EDT
> W: system-config-kickstart summary-ended-with-dot A graphical interface for
> making kickstart files.

Fixed.

> E: system-config-kickstart tag-not-utf8 %changelog
> E: system-config-kickstart non-utf8-spec-file system-config-kickstart.spec
> W: system-config-kickstart macro-in-%changelog packages
> W: system-config-kickstart macro-in-%changelog doc

I think the first two are complaining about someone's name in a changelog entry
from 2002.  All of these require going back and modifying the changelog, which
I'm not really excited about doing unless I absolutely have to.

> W: system-config-kickstart no-%build-section
> 
> The Source0 field should contain the URL to the downloadable source or a comment
> like this above it:
> 
> # This is a Red Hat maintained package which is specific to
> # our distribution.  Thus the source is only available from
> # within this srpm.
> 
> BuildRoot should be:
> %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> 
> Personal opinion: group Obsoletes, BuildRequires, and Requires items on to a
> smaller number of lines?
> 
> %{buildroot} vs. $RPM_BUILD_ROOT
> 
> Line 17 has a trailing space.
> 
> In %files, use %defattr(-,root,root,-)
> 
> Use path macros in %files section.
> 
> Make sure desktop-file-install usage is per the guidelines:
>
http://fedoraproject.org/wiki/Packaging/Guidelines#head-d559ee7363418a5840ce63090c608c991cd39ce6

Fixed.

Note You need to log in before you can comment on or make changes to this bug.