Need some SPEC cleanups as rpmlint gave me 
system-config-network.src:11: W: unversioned-explicit-obsoletes isdn-config
system-config-network.src:11: W: unversioned-explicit-obsoletes internet-config
system-config-network.src:11: W: unversioned-explicit-obsoletes rp3
system-config-network.src:11: W: unversioned-explicit-obsoletes
redhat-config-network
system-config-network.src:25: W: unversioned-explicit-obsoletes netcfg
system-config-network.src:25: W: unversioned-explicit-obsoletes
redhat-config-network-tui
system-config-network.src:25: W: unversioned-explicit-obsoletes netconfig
==>  The specfile contains an unversioned Obsoletes: token, which will match all
older, equal and newer versions of the obsoleted thing.  This may cause update
problems, restrict future package/provides naming, and may match something it
was originally not inteded to match -- make the Obsoletes versioned if
possible.

system-config-network.src:26: W: unversioned-explicit-provides
redhat-config-network-tui

==>The specfile contains an unversioned Provides: token, which will match all
older, equal, and newer versions of the provided thing.  This may cause
update problems and will make versioned dependencies, obsoletions and conflicts
on the provided thing useless -- make the Provides versioned if possible.


system-config-network.src: W: invalid-license GPL
system-config-network.noarch: W: no-documentation
system-config-network.noarch: W: no-dependency-on usermode
system-config-network.noarch: E: explicit-lib-dependency libglade2
==> You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.

system-config-network.noarch: W: invalid-license GPL
system-config-network.noarch: W: obsolete-not-provided isdn-config
system-config-network.noarch: W: obsolete-not-provided internet-config
system-config-network.noarch: W: obsolete-not-provided rp3
system-config-network-tui.noarch: W: no-documentation
system-config-network-tui.noarch: E: non-executable-script
/usr/share/system-config-network/netconfpkg/exception.py 0644
system-config-network-tui.noarch: W: invalid-license GPL
==> Update Licenst tag

system-config-network-tui.noarch: W: obsolete-not-provided netcfg
system-config-network-tui.noarch: W: obsolete-not-provided netconfig
==> If a package is obsoleted by a compatible replacement, the obsoleted package
must also be provided in order to provide clean upgrade paths and not cause
unnecessary dependency breakage.  If the obsoleting package is not a compatible
replacement for the old one, leave out the provides.

Also,
  Good to use %defattr(-,root,root,-)


Update package. Better to provide new SPEC and SRPM links for this package
before actually committing in CVS.

ping? any updates?

New specfile and src.rpm
http://people.redhat.com/harald/downloads/system-config-network/system-config-network-1.4.4-1.fc8/

Thanks for updates.
With updated SRPM I got following rpmlint messages
system-config-network.noarch: W: incoherent-version-in-changelog 1.4.4 1.4.4-1.fc8
system-config-network.noarch: W: obsolete-not-provided rp3
system-config-network.src: W: strange-permission system-config-network.spec 0600

otherwise package looks ok.

system-config-network.noarch: W: incoherent-version-in-changelog 1.4.4 1.4.4-1.fc8
- minor lazyness, b/c this is upstream and releases are normally not incremented

system-config-network.noarch: W: obsolete-not-provided rp3
- The rp3 interface is not provided, but rp3 is obsoleted nevertheless

system-config-network.src: W: strange-permission system-config-network.spec 0600
- will go away, if I build the package in the Fedora infrastructure (this was,
make dist && rpm -ta <tarfile>)

Review:
+ package builds in mock (development i386).
- rpmlint is Not silent for SRPM but Not for RPM.
system-config-network.noarch: W: incoherent-version-in-changelog 1.4.4 1.4.4-1.fc8
=> I hope you will take care this message while building package next time.
system-config-network.noarch: W: obsolete-not-provided rp3
=>This messages can be ignored for this package.
system-config-network.src: W: strange-permission system-config-network.spec 0600
=> I hope you will take care this message while building package next time.
+ source files match upstream.
9566acdbecea85601ecc39c71a3e24fa  system-config-network-1.4.4.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ gtk-update-icon-cache scriptlets are used.
+ Desktop files are handled correctly.
+ package system-config-network-1.4.4-1.fc8 ->
  Provides: internet-config = 0.40-2.1 isdn-config = 0.18-10.70.1
redhat-config-network = 1.4.4
  Requires: /usr/bin/python gnome-python2 gnome-python2-canvas pygtk2
pygtk2-libglade system-config-network-tui = 1.4.4-1.fc8 usermode
+ package system-config-network-tui-1.4.4-1.fc8 ->
  Provides: config(system-config-network-tui) = 1.4.4-1.fc8 netcfg = 2.36-3p.1
netconf = 0.1-1.1 redhat-config-network-tui = 1.4.4
  Requires: /bin/sh /usr/bin/python config(system-config-network-tui) =
1.4.4-1.fc8 initscripts >= 0:5.99 kudzu newt-python pciutils python rhpl >=
0:0.193 rpm-python usermode
+ GUI app.

APPROVED.

ping?
is the srpm given in comment #3 is built?

no, not yet, because F8 was closed

Can we now import new SRPM in rawhide?

https://admin.fedoraproject.org/updates/F8/pending/system-config-network-1.4.5-1.fc8

you can build for devel also and then we can CLOSE this review.

I don't see approved package built for f8 or f9.

http://download.fedora.redhat.com/pub/fedora/linux/development/source/SRPMS/system-config-network-1.5.0-1.fc9.src.rpm

thanks

Package Change Request
======================
Package Name: system-config-network
New Branches: F-10

I will prefer this review done by me to be in assigned state to me :)

You already closed it :) 

Parag AN(पराग)  	2007-12-06 09:36 EST  	Status  	ASSIGNED  	CLOSED
Resolution 	  	RAWHIDE

Yes I closed it because this package already completed its review and was in
rawhide at time of closing this.

Please don't remove fedora-review+ flags.Therefore setting it again.

(In reply to comment #16)
> I will prefer this review done by me to be in assigned state to me :)

yup. I mean to say let the reviews be assigned to reviewer at time of closing
reviews. You reset Assigned to nobody


Harald Hoyer  	2008-03-26 21:11 EST  	CC  	    	notting,
fedora-package-review
AssignedTo 	panemade 	nobody
Status 	ASSIGNED 	CLOSED
QAContact 	fedora-package-review 	extras-qa
Resolution 	  	RAWHIDE
Flag 	fedora-cvs+ 	fedora-cvs? 

sry, accidently reopened it, while I just should have set the fedora-cvs flag to "?"

cvs done. 

Note that your new F-9 branch is a clone from current devel. 
You will want to do your F-10/unstable work in the devel branch now. 

No need to open this review now as cvs is done :)