Hi there,

Review for release 5:
* RPM name is OK
* Source tree-1.5.0.tgz is the same as upstream
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* Package is marked as relocatable, please check.
  (wiki: PackagingGuidelines#RelocatablePackages)
* Spec file: some paths are not replaced with RPM macros
  (wiki: QAChecklist item 7)
* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)
  Just add LICENSE from the source to %doc
* Preserve timestamps when you install files

Rpmlint is not silent:

Source RPM:
W: tree summary-ended-with-dot A utility which displays a tree view of the contents of directories.
W: tree hardcoded-prefix-tag /usr
W: tree hardcoded-path-in-buildroot-tag /var/tmp/tree-root

rpmlint of tree:
W: tree summary-ended-with-dot A utility which displays a tree view of the contents of directories.

Thanks!  Should be all fixed in 1.5.0-6.fc7.

Thanks Tim, this looks good.
One question though, why do you rm -rf tree in %build? I think rpmbuild does this by default.

I don't see any blockers, so this package is approved. Please leave the ticket assigned to yourself.

A previous tarball shipped the tree binary(!) along with the source.  Current
version doesn't do that so I'll remove the rm.

Thanks!

Can I set the resolution to 'RAWHIDE' or something?

If you want, you can set it to closed rawhide.
We're only planning on looking at the fedora-review flag. If that's a +, the
package is approved.

Thanks,

Ruben