This service will be undergoing maintenance at 00:00 UTC, 2017-10-23 It is expected to last about 30 minutes
Bug 226503 - Merge Review: tree
Merge Review: tree
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Tim Waugh
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 16:12 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-02-07 07:32:32 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ruben: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 16:12:25 EST
Fedora Merge Review: tree

http://cvs.fedora.redhat.com/viewcvs/devel/tree/
Initial Owner: twaugh@redhat.com
Comment 1 Ruben Kerkhof 2007-02-04 11:25:25 EST
Hi there,

Review for release 5:
* RPM name is OK
* Source tree-1.5.0.tgz is the same as upstream
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* Package is marked as relocatable, please check.
  (wiki: PackagingGuidelines#RelocatablePackages)
* Spec file: some paths are not replaced with RPM macros
  (wiki: QAChecklist item 7)
* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)
  Just add LICENSE from the source to %doc
* Preserve timestamps when you install files

Rpmlint is not silent:

Source RPM:
W: tree summary-ended-with-dot A utility which displays a tree view of the contents of directories.
W: tree hardcoded-prefix-tag /usr
W: tree hardcoded-path-in-buildroot-tag /var/tmp/tree-root

rpmlint of tree:
W: tree summary-ended-with-dot A utility which displays a tree view of the contents of directories.
Comment 2 Tim Waugh 2007-02-06 12:09:59 EST
Thanks!  Should be all fixed in 1.5.0-6.fc7.
Comment 3 Ruben Kerkhof 2007-02-06 14:54:14 EST
Thanks Tim, this looks good.
One question though, why do you rm -rf tree in %build? I think rpmbuild does this by default.

I don't see any blockers, so this package is approved. Please leave the ticket assigned to yourself.
Comment 4 Tim Waugh 2007-02-07 04:57:53 EST
A previous tarball shipped the tree binary(!) along with the source.  Current
version doesn't do that so I'll remove the rm.

Thanks!

Can I set the resolution to 'RAWHIDE' or something?
Comment 5 Ruben Kerkhof 2007-02-07 07:27:51 EST
If you want, you can set it to closed rawhide.
We're only planning on looking at the fedora-review flag. If that's a +, the
package is approved.

Thanks,

Ruben

Note You need to log in before you can comment on or make changes to this bug.