Review for release 2.2.1:
* RPM name is OK
* Source unzip552.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Encoding should be UTF-8
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* Spec file: some paths are not replaced with RPM macros
  (wiki: QAChecklist item 7)
* Preserve timestamps with cp -p when installing files

Notes:
* Please consider using {?dist} (fedoraproject.org/wiki/DistTag)

I got a warning during building, is this expected?
ln: creating hard link `./Makefile' to `unix/Makefile': File exists

Rpmlint is not silent: 

Source RPM:
W: unzip summary-ended-with-dot A utility for unpacking zip files.
E: unzip tag-not-utf8 %changelog
E: unzip non-utf8-spec-file unzip.spec

rpmlint of unzip:
W: unzip summary-ended-with-dot A utility for unpacking zip files.
E: unzip tag-not-utf8 %changelog

Fixed in unzip-5.52-3.fc7.

Hi Ivana,

Thanks for fixing all the above-mentioned issues. I don't see any further blockers, so this package is 
approved.

Please leave the ticket assigned to yourself.

Ruben

Only if you insist on keeping the "INSTALL" file in %doc, keep it.
Else drop it, as it is compile-from-source stuff that is irrelevant
to RPM package end-users.

Fixed in unzip-5.52-4.fc7

Unsetting fedora-cvs, as Core Merge Reviews are already in CVS, and will be part
of the mass move when we are ready to merge the distro later.