Spec URL: http://people.redhat.com/rafaels/specs/plexus-i18n-1.0-0.b6.3jpp.spec SRPM URL: ftp://jpackage.hmdc.harvard.edu/JPackage/1.7/generic/SRPMS.free/plexus-i18n-1.0-0.b6.3jpp.src.rpm Description: The Plexus project seeks to create end-to-end developer tools for writing applications. At the core is the container, which can be embedded or for a full scale application server. There are many reusable components for hibernate, form processing, jndi, i18n, velocity, etc. Plexus also includes an application server which is like a J2EE application server, without all the baggage. Javadoc for plexus-i18n.
Here's the link to the udpated spec file and source rpm: http://tequila-sunrise.ath.cx/rpmreviews/F7/plexus/
plexus-i18n-1.0-0.b6.3jpp.1.src.rpm Legend: OK: passes criteria NO: fails criteria (errors included between "--" markers) NA: non applicable ??: unable to verify MUST: OK * package is named appropriately OK - match upstream tarball or project name OK - try to match previous incarnations in other distributions/packagers for consistency OK - specfile should be %{name}.spec OK - non-numeric characters should only be used in Release (ie. cvs or something) OK - for non-numerics (pre-release, CVS snapshots, etc.), see http://fedoraproject.org/wiki/Packaging/NamingGuidelines#PackageRelease OK - if case sensitivity is requested by upstream or you feel it should be not just lowercase, do so; otherwise, use all lower case for the name OK * is it legal for Fedora to distribute this? OK - OSI-approved OK - not a kernel module OK - not shareware OK - is it covered by patents? OK - it *probably* shouldn't be an emulator OK - no binary firmware OK * license field matches the actual license. OK * license is open source-compatible. OK * specfile name matches %{name} OK * verify source and patches (md5sum matches upstream, know what the patches do) OK * skim the summary and description for typos, etc. OK * correct buildroot OK * if %{?dist} is used, it should be in that form (note the ? and % locations) NA * license text included in package and marked with %doc OK * keep old changelog entries; use judgement when removing (too old? useless?) OK * packages meets FHS (http://www.pathname.com/fhs/) NO * rpmlint on <this package>.srpm gives no output - justify warnings if you think they shouldn't be there -- $ rpmlint plexus-i18n-1.0-0.b6.3jpp.1.src.rpm W: plexus-i18n non-standard-group Development/Java W: plexus-i18n mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 69) (minor warnings, should be ok) -- OK * changelog should be in one of these formats: OK * Packager tag should not be used OK * Vendor tag should not be used OK * use License and not Copyright OK * Summary tag should not end in a period NA * if possible, replace PreReq with Requires(pre) and/or Requires(post) OK * specfile is legible ?? * package successfully compiles and builds on at least x86 ?? * BuildRequires are proper OK * summary should be a short and concise description of the package OK * description expands upon summary (don't include installation instructions) OK * make sure lines are <= 80 characters OK * specfile written in American English OK * make a -doc sub-package if necessary NA * packages including libraries should exclude static libraries if possible OK * don't use rpath NA * config files should usually be marked with %config(noreplace) NA * GUI apps should contain .desktop files NA * should the package contain a -devel sub-package? OK * use macros appropriately and consistently OK * don't use %makeinstall NA * locale data handling correct (find_lang) OK * consider using cp -p to preserve timestamps NA * split Requires(pre,post) into two separate lines OK * package should probably not be relocatable OK * package contains code OK * package should own all directories and files OK * there should be no %files duplicates OK * file permissions should be okay; %defattrs should be present OK * %clean should be present OK * %doc files should not affect runtime NA * if it is a web apps, it should be in /usr/share/%{name} and *not* /var/www ?? * verify the final provides and requires of the binary RPMs ?? * run rpmlint on the binary RPMs SHOULD: NA * package should include license text in the package and mark it with %doc ?? * package should build on i386 ?? * package should build in mock
> NO * rpmlint on <this package>.srpm gives no output > - justify warnings if you think they shouldn't be there > > -- > $ rpmlint plexus-i18n-1.0-0.b6.3jpp.1.src.rpm > W: plexus-i18n mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 69) > (minor warnings, should be ok) That's strange. When I run rpmlint on plexus-i18n-1.0-0.b6.3jpp.1.src.rpm, I don't get this warning.
Maybe it's different versions of rpmlint... here's what I'm using, for reference: $ rpmlint --version rpmlint version 0.79 Copyright (C) 1999-2006 Frederic Lepied, Mandriva and am still getting the warnings above on the updated SRPM: $ ls -alF plexus-i18n-1.0-0.b6.3jpp.1.src.rpm ; rpmlint plexus-i18n-1.0-0.b6.3jpp.1.src.rpm -rw-r--r-- 1 nsantos nsantos 16437 Feb 20 10:48 plexus-i18n-1.0-0.b6.3jpp.1.src.rpm W: plexus-i18n non-standard-group Development/Java W: plexus-i18n mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 69) In any case, since the warnings are minor and you're not seeing them, I'm marking as fedora-review+
New Package CVS Request ======================= Package Name: plexus-i18n Short Description: Plexus I18N Component Owners: pcheung Branches: InitialCC:
Package built into plague. Closing as NEXTRELEASE.