Bug 2271961 - README.fedora.md has instruction error
Summary: README.fedora.md has instruction error
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: corectrl
Version: 40
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Artem
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-03-27 22:33 UTC by M. Schlegel
Modified: 2024-05-16 15:03 UTC (History)
1 user (show)

Fixed In Version: corectrl-1.3.11-2.fc41 corectrl-1.4.0-2.fc40 corectrl-1.4.0-3.fc41
Clone Of:
Environment:
Last Closed: 2024-05-05 20:14:52 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description M. Schlegel 2024-03-27 22:33:29 UTC
The README.fedora.md contained in corectrl-1.3.11-1.fc40.x86_64 suggests copying the file desktop file in this manner:

cp /usr/share/applications/corectrl.desktop ~/.config/autostart/corectrl.desktop

however this file path does not exist, it should be:

/usr/share/applications/org.corectrl.corectrl.desktop

So the README.fedora.md should be modified so that is:

cp /usr/share/applications/org.corectrl.corectrl.desktop ~/.config/autostart/corectrl.desktop

Reproducible: Always

Steps to Reproduce:
1.install corectrl package
2.view contained README.fedora.md
3.the quoted path to copy the .desktop template from to the user's .config/autostart/ area is wrong
Actual Results:  
The instructions on how to copy the corectrl desktop file is showing an nonexistent path

Expected Results:  
The instructions in the md file on how to copy the corectrl desktop file should refer to a path that exists in the rpm

It's possible the filename of the desktop file itself is wrong, "org.corectrl.corectrl.desktop" seems a bit redundant but it's up to the developer to confirm the filename. Maybe it should be "org.corectrl.desktop"

Comment 1 Artem 2024-05-05 19:35:31 UTC
Thanks for reporting. This happened after upstream changed to canonical RDNS name scheme. I plan to include rh#2271961 fix with next CoreCtrl update.

Comment 2 Fedora Update System 2024-05-05 20:12:09 UTC
FEDORA-2024-b12bf5ee52 (corectrl-1.3.11-2.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-b12bf5ee52

Comment 3 Fedora Update System 2024-05-05 20:14:52 UTC
FEDORA-2024-b12bf5ee52 (corectrl-1.3.11-2.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 4 Fedora Update System 2024-05-05 21:13:37 UTC
FEDORA-2024-f563948194 (corectrl-1.4.0-2.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-f563948194

Comment 5 M. Schlegel 2024-05-05 22:39:13 UTC
I didn't actually install the package but simply grabbed the 1.4.0-2 rpm from the bodhi page and then used rpm2cpio/cpio to look in the README.fedora.md file grepped to the desktop line:

$ rpm2cpio corectrl-1.4.0-2.fc40.x86_64.rpm | cpio -i --to-stdout ./usr/share/doc/corectrl/README.fedora.md | grep desktop

cp /usr/share/applications/org.corectrl.corectrl.desktop ~/.config/autostart/corectrl.desktop

$ rpm -qlvp corectrl-1.4.0-2.fc40.x86_64.rpm | grep desktop
-rw-r--r--    1 root     root     836 Mar 17 07:10 /usr/share/applications/org.corectrl.CoreCtrl.desktop


The actual file on the filesystem has a Camel Typed name "org.corectrl.CoreCtrl.desktop" so either the "cp" sample in the README should do the same or the file in the rpm shouldn't be camelized. Obviously experienced users will figure out the spelling issue but less advanced users would be confused to get the "No such file or directory" error

Comment 6 Fedora Update System 2024-05-06 01:38:43 UTC
FEDORA-2024-f563948194 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f563948194`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f563948194

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2024-05-14 01:26:20 UTC
FEDORA-2024-f563948194 (corectrl-1.4.0-2.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2024-05-15 11:16:44 UTC
FEDORA-2024-6a5e77cfd9 (corectrl-1.4.0-3.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6a5e77cfd9

Comment 9 Artem 2024-05-15 11:34:31 UTC
(In reply to M. Schlegel from comment #5)

Thanks for providing feedback. Should be fixed in corectrl-1.4.0-3.

I did exactly as you said in OP and didn't tested this myself. My mistake. Ideally we should do some checks during build to prevent such downstream changes in future. But this time consuming a little bit.

Comment 10 Fedora Update System 2024-05-15 15:44:13 UTC
FEDORA-2024-6a5e77cfd9 (corectrl-1.4.0-3.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 M. Schlegel 2024-05-15 16:52:08 UTC
"I did exactly as you said in OP and didn't tested this myself"


I was quoting the filename that was on my filesystem from the old package. Apparently it's not even in gitlab with that name but it's "launcher.desktop"

git clone https://gitlab.com/corectrl/corectrl.git
cd corectrl
diff resources/launcher.desktop /usr/share/applications/org.corectrl.CoreCtrl.desktop
(files are the same)

grep -nE "desktop|PROJECT_FQDN" CMakeLists.txt 
4:set(PROJECT_FQDN "org.corectrl.CoreCtrl")
100:  FILES resources/launcher.desktop
102:  RENAME ${PROJECT_FQDN}.desktop

Apparently there's some reason the file can't just have that name in git but has to be renamed.

Comment 12 Artem 2024-05-16 15:03:56 UTC
(In reply to M. Schlegel from comment #11)

Yep, no worries. I've pushed update[1] also for f39, f40. Testing is still very wanted as always. Thanks one more time.

[1]: https://bodhi.fedoraproject.org/updates/?packages=corectrl


Note You need to log in before you can comment on or make changes to this bug.