Bug 2278651 - Syntax error in qbs patch
Summary: Syntax error in qbs patch
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: qbs
Version: 40
Hardware: All
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Sandro Mani
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-05-02 15:20 UTC by Thorbjørn Lindeijer
Modified: 2024-05-16 01:52 UTC (History)
4 users (show)

Fixed In Version: qbs-2.3.1-2.fc40
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-05-16 01:52:01 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Thorbjørn Lindeijer 2024-05-02 15:20:00 UTC
Description of problem:

I've run into an issue that was introduced by the following patch, which is applied in the Fedora package:

https://src.fedoraproject.org/rpms/qbs/blob/rawhide/f/qbs_qmake.patch

The issue is due to broken JS syntax:

/usr/share/qbs/imports/qbs/Probes/qbs-pkg-config-probe.js:79:37 Expected token `,'

Please update this patch, making sure the qtsuffix string literals include an ending quote.

Version-Release number of selected component (if applicable):

Problem introduced in https://src.fedoraproject.org/rpms/qbs/c/30a61500c7b07d32fd49e548f6b5c99f6f30d254

How reproducible:

Try to run qbs to build a project. It likely breaks on many, but I tested it only with https://github.com/mapeditor/tiled.

Actual results:

You see the error reported above.

Expected results:

Qbs works.

Additional info:

Please try to upstream any changes to Qbs. This helps catch such issues earlier and also makes sure that other versions of Qbs, like the one distributed alongside Qt Creator, are also able to handle the way Fedora is set up.

Thank you for maintaining this package!

Comment 1 Fedora Update System 2024-05-02 16:25:07 UTC
FEDORA-2024-efb877c04b (qbs-2.3.0-2.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-efb877c04b

Comment 2 Fedora Update System 2024-05-03 03:11:49 UTC
FEDORA-2024-efb877c04b has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-efb877c04b`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-efb877c04b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 3 Fedora Update System 2024-05-08 02:21:50 UTC
FEDORA-2024-2d8f676e01 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-2d8f676e01`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-2d8f676e01

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 4 Thorbjørn Lindeijer 2024-05-08 08:28:36 UTC
Only one of the missed quotes was fixed by the released patch. With qbs-1:2.3.1-1.fc40.x86_64 installed, the error has changed to: 

ERROR: /home/bjorn/projects/tiled/src/libtiled/libtiled.qbs /usr/share/qbs/imports/qbs/Probes/qbs-pkg-config-probe.js:83:45 Expected token `,'

Because there is still a missing ending quote for the "-qt6" suffix.

Comment 5 Sandro Mani 2024-05-08 09:41:12 UTC
Sorry something went wrong, should be fixed in qbs-2.3.1-2.fc41

Comment 6 Fedora Update System 2024-05-08 09:41:30 UTC
FEDORA-2024-a3fdd2f625 (qbs-2.3.1-2.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-a3fdd2f625

Comment 7 Fedora Update System 2024-05-08 19:36:10 UTC
FEDORA-2024-a3fdd2f625 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-a3fdd2f625`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-a3fdd2f625

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Thorbjørn Lindeijer 2024-05-14 13:47:18 UTC
I've installed the FEDORA-2024-a3fdd2f625 version and the issue is fixed now, thank you!

Comment 9 Fedora Update System 2024-05-16 01:52:01 UTC
FEDORA-2024-a3fdd2f625 (qbs-2.3.1-2.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.