Red Hat Bugzilla – Bug 228294
Review Request: gkrellm-sun - Sun clock plugin for GKrellM
Last modified: 2007-11-30 17:11:57 EST
Spec URL: http://ftp.es6.freshrpms.net/tmp/extras/gkrellm-sun/
SRPM URL: http://ftp.es6.freshrpms.net/tmp/extras/gkrellm-sun/
A sun clock plugin for GKrellM which can display the sun's setting time, rising
time, path and current location and so on.
This is a pretty trivial package. Notes :
- The name "gkrellsun" has been changed to be in the "gkrellm-*" namespace.
- No configure, so the Makefile's FLAGS have been (ab)used to pass our optflags.
- Explicit "gkrellm" requirement set because of the version it needs.
- The very similar "gkrellm-moon" package will also be submitted by itself.
The gkrellm-moon package is bug #228293 in case someone wants to review both
packages at once and save testing time.
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
OK - BuildRequires correct
See below - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version
1. Default perms are
%defattr(-, root, root, 0755)
Can that be changed to:
%defattr(-, root, root, -)
2. Please use the one true build root(tm):
1. OK, it's changed to %defattr(-,root,root,-)
2. It's a matter of personal taste and a dislike of sticky futile exec()s :-)
gkrellm-sun-1.0.0-2.fc6.src.rpm and an updated spec file are available from the
1. good. ok.
2. Well, it was recently decided that the current preferred buildroot should be
The longer term plan is to have rpmbuild setup some sane buildroot and not need
to specify it in the spec file at all.
So, could you pretty please change it, and then I can approve this (and
Argh. A useless stupid change is guidelines. The "id" execution to build up the
buildroot has been known to make my mach rebuilds fail, which is the main
technical reason why I have always avoided it. I've asked on the extras-list
what the rationale behind this change is...
In reply to comment #5:
Unfortunately, nothing useful seems to have come out of the discussion on
Would you be willing to change the buildroot here (and in gkrellm-moon/any other
blocked submissions) to get them approved for now, and then work with the
package committee to get some more acceptable buildroot solution ratified down
ok. Today FESCO ratified the buildroot proposal at:
The buildroot here meets those guidelines, so this package is APPROVED.
Don't forget to close this once it's been imported and built.
New Package CVS Request
Package Name: gkrellm-sun
Short Description: Sun clock plugin for GKrellM
Branches: FC-5 FC-6 devel EL-4 EL-5
(I still don't have rights to set the fedora-cvs flag...)