Spec URL: https://dcavalca.fedorapeople.org/review/rust-apple-sdk/rust-apple-sdk.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-apple-sdk/rust-apple-sdk-0.5.2-1.fc41.src.rpm Description: Interact with Apple SDKs. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=118460834
Copr build: https://copr.fedorainfracloud.org/coprs/build/7522381 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2284286-rust-apple-sdk/fedora-rawhide-x86_64/07522381-rust-apple-sdk/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The src/testfiles/ directory contains some files that appear to be from macOS. They look harmless enough (just compiler settings?), but please verify that they are OK for us to redistribute. Additionally, it might make sense to exclude them from the "-devel" subpackage since they're only used for tests.
Looks like these are small example configuration files, I'm pretty sure these are fine to redistribute.
Spec URL: https://dcavalca.fedorapeople.org/review/rust-apple-sdk/rust-apple-sdk.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-apple-sdk/rust-apple-sdk-0.5.2-1.fc41.src.rpm Changelog: - exclude testfiles from -devel
Looks good to me! === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-apple-sdk
FEDORA-2024-2d4fb893a2 (rust-apple-sdk-0.5.2-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-2d4fb893a2
FEDORA-2024-2d4fb893a2 (rust-apple-sdk-0.5.2-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-1cb891ee3e (rust-apple-sdk-0.5.2-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-1cb891ee3e
FEDORA-2024-89d11fbfe1 (rust-apple-sdk-0.5.2-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-89d11fbfe1
FEDORA-2024-89d11fbfe1 (rust-apple-sdk-0.5.2-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-1cb891ee3e (rust-apple-sdk-0.5.2-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.